Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore support for the memcached/metrics input. #2298

Merged
merged 2 commits into from Feb 21, 2023
Merged

Restore support for the memcached/metrics input. #2298

merged 2 commits into from Feb 21, 2023

Conversation

cmacknz
Copy link
Member

@cmacknz cmacknz commented Feb 21, 2023

We lost support for the memcached/metrics input in 8.6 when we introduced the new specification file syntax. This PR adds it back.

@elastic/obs-service-integrations FYI since it looks like this integration is yours
https://github.com/elastic/integrations/blob/cde97a82070665c8e2e0780401f6d4c5ceafb734/.github/CODEOWNERS#L128

@cmacknz cmacknz added Team:Elastic-Agent Label for the Agent team Team:Service-Integrations Label for the Service Integrations team backport-v8.7.0 Automated backport with mergify labels Feb 21, 2023
@cmacknz cmacknz requested a review from a team as a code owner February 21, 2023 17:35
@cmacknz cmacknz self-assigned this Feb 21, 2023
@cmacknz cmacknz requested review from ycombinator and blakerouse and removed request for a team February 21, 2023 17:35
@elasticmachine
Copy link
Collaborator

elasticmachine commented Feb 21, 2023 •
edited

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-02-21T18:10:02.942+0000

  • Duration: 16 min 17 sec

Test stats 🧪

Test Results
Failed 0
Passed 4919
Skipped 15
Total 4934

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages.

  • run integration tests : Run the Elastic Agent Integration tests.

  • run end-to-end tests : Generate the packages and run the E2E Tests.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@elasticmachine
Copy link
Collaborator

elasticmachine commented Feb 21, 2023 •
edited

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 98.361% (60/61) 👍
Files 68.9% (144/209) 👍
Classes 68.08% (273/401) 👍
Methods 53.517% (837/1564) 👍
Lines 38.844% (9177/23625) 👍 0.008
Conditionals 100.0% (0/0) 💚

@cmacknz
Copy link
Member Author

cmacknz commented Feb 21, 2023

/test

@cmacknz
Copy link
Member Author

cmacknz commented Feb 21, 2023

I can confirm the memcached tests in the integrations repository are currently failing without this fix

cd integrations/packages/memcached
elastic-package build -v
elastic-package stack up -v -d --version 8.6.0-SNAPSHOT
elastic-package test -v
...
Error: error running package system tests: could not complete test run: could not find hits in metrics-memcached.stats-ep data stream

ycombinator
ycombinator approved these changes Feb 21, 2023
View reviewed changes
Copy link
Contributor

@ycombinator ycombinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@cmacknz cmacknz merged commit cb63711 into elastic:main Feb 21, 2023
mergify bot pushed a commit that referenced this pull request Feb 21, 2023
@cmacknz @mergify
Restore support for the memcached/metrics input. (#2298)
5f6ddde 
* Restore support for memcached/metrics input.

* Add PR and issue to changelog.

(cherry picked from commit cb63711)
@mergify mergify bot mentioned this pull request Feb 21, 2023
Merged
@cmacknz cmacknz deleted the support-memcached-metrics-input branch February 21, 2023 19:26
cmacknz added a commit that referenced this pull request Feb 21, 2023
@mergify @cmacknz
Restore support for the memcached/metrics input. (#2298) (#2299)
e88a5bc 
* Restore support for memcached/metrics input.

* Add PR and issue to changelog.

(cherry picked from commit cb63711)

Co-authored-by: Craig MacKenzie <craig.mackenzie@elastic.co>
@cmacknz cmacknz added the backport-v8.6.0 Automated backport with mergify label Feb 22, 2023
mergify bot pushed a commit that referenced this pull request Feb 22, 2023
@cmacknz @mergify
Restore support for the memcached/metrics input. (#2298)
64be5cd 
* Restore support for memcached/metrics input.

* Add PR and issue to changelog.

(cherry picked from commit cb63711)
@mergify mergify bot mentioned this pull request Feb 22, 2023
Merged
cmacknz added a commit that referenced this pull request Feb 22, 2023
@mergify @cmacknz
Restore support for the memcached/metrics input. (#2298) (#2305)
70e8282 
* Restore support for memcached/metrics input.

* Add PR and issue to changelog.

(cherry picked from commit cb63711)

Co-authored-by: Craig MacKenzie <craig.mackenzie@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ycombinator ycombinator ycombinator approved these changes

@blakerouse blakerouse Awaiting requested review from blakerouse blakerouse is a code owner automatically assigned from elastic/elastic-agent-control-plane

@michalpristas michalpristas Awaiting requested review from michalpristas

Assignees

@cmacknz cmacknz

Labels
backport-v8.6.0 Automated backport with mergify backport-v8.7.0 Automated backport with mergify Team:Elastic-Agent Label for the Agent team Team:Service-Integrations Label for the Service Integrations team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Agent unhealthy after adding Memcached integration
3 participants
@cmacknz @elasticmachine @ycombinator