Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Watcher: Fix notification channel for crashes #2320

Merged

Conversation

ycombinator
Copy link
Contributor

@ycombinator ycombinator commented Feb 24, 2023

What does this PR do?

This PR fixes a small bug where the incorrect log message was being emitted by the Upgrade Watcher if a crash was detected by it.

Why is it important?

For more accurate troubleshooting.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@ycombinator ycombinator added >bug backport-v8.7.0 Automated backport with mergify labels Feb 24, 2023
@ycombinator ycombinator requested a review from a team as a code owner February 24, 2023 16:18
@ycombinator ycombinator requested review from AndersonQ and blakerouse and removed request for a team February 24, 2023 16:18
@ycombinator ycombinator force-pushed the bugfix-upgrade-watcher-crash-chan branch from e3a4b89 to 54b4249 Compare February 24, 2023 16:20
@elasticmachine
Copy link
Collaborator

elasticmachine commented Feb 24, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-02-24T16:21:23.001+0000

  • Duration: 16 min 9 sec

Test stats 🧪

Test Results
Failed 0
Passed 4919
Skipped 15
Total 4934

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages.

  • run integration tests : Run the Elastic Agent Integration tests.

  • run end-to-end tests : Generate the packages and run the E2E Tests.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@elasticmachine
Copy link
Collaborator

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 98.361% (60/61) 👍
Files 68.9% (144/209) 👍
Classes 68.08% (273/401) 👍
Methods 53.517% (837/1564) 👍
Lines 38.872% (9184/23626) 👍 0.034
Conditionals 100.0% (0/0) 💚

Copy link
Member

@cmacknz cmacknz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, also the reason we didn't catch is probably that viewing the upgrade watcher logs is exceptionally hard when analyzing previously failed upgrades #2262

@ycombinator ycombinator merged commit 98b8fe7 into elastic:main Feb 24, 2023
@ycombinator ycombinator deleted the bugfix-upgrade-watcher-crash-chan branch February 24, 2023 18:31
mergify bot pushed a commit that referenced this pull request Feb 24, 2023
* Fix notification channel for crashes

* Adding CHANGELOG fragment

(cherry picked from commit 98b8fe7)
ycombinator added a commit that referenced this pull request Feb 24, 2023
* Fix notification channel for crashes

* Adding CHANGELOG fragment

(cherry picked from commit 98b8fe7)

Co-authored-by: Shaunak Kashyap <ycombinator@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v8.7.0 Automated backport with mergify >bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants