Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring fake component and shipper codebases #2378

Merged
merged 4 commits into from
Mar 20, 2023

Conversation

ycombinator
Copy link
Contributor

What does this PR do?

This PR refactors the fake component and shipper codebases, in preparation for #2218.

Why is it important?

To reduce noise in #2218, hopefully making it a bit easier to review.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@ycombinator ycombinator added Cleanup backport-v8.7.0 Automated backport with mergify labels Mar 20, 2023
@ycombinator ycombinator requested a review from a team as a code owner March 20, 2023 14:41
@ycombinator ycombinator requested review from michalpristas, pchila and AndersonQ and removed request for a team March 20, 2023 14:41
@elasticmachine
Copy link
Collaborator

elasticmachine commented Mar 20, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-03-20T16:53:10.034+0000

  • Duration: 17 min 49 sec

Test stats 🧪

Test Results
Failed 0
Passed 5003
Skipped 15
Total 5018

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages.

  • run integration tests : Run the Elastic Agent Integration tests.

  • run end-to-end tests : Generate the packages and run the E2E Tests.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@ycombinator ycombinator marked this pull request as draft March 20, 2023 15:01
go.mod Outdated Show resolved Hide resolved
@ycombinator ycombinator force-pushed the refactor-fakes branch 2 times, most recently from 19b5046 to 53646be Compare March 20, 2023 15:27
@elasticmachine
Copy link
Collaborator

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 98.387% (61/62) 👍
Files 68.868% (146/212) 👍
Classes 67.98% (276/406) 👍
Methods 53.455% (851/1592) 👍
Lines 38.802% (9429/24300) 👎 -0.037
Conditionals 100.0% (0/0) 💚

@ycombinator ycombinator marked this pull request as ready for review March 20, 2023 17:20
@ycombinator ycombinator merged commit ec1072a into elastic:main Mar 20, 2023
@ycombinator ycombinator deleted the refactor-fakes branch March 20, 2023 17:57
mergify bot pushed a commit that referenced this pull request Mar 20, 2023
* Refactoring fake component and shipper codebases

* Fixing imports

* Silence the linter

* Make go build happy

(cherry picked from commit ec1072a)
ycombinator added a commit that referenced this pull request Mar 20, 2023
* Refactoring fake component and shipper codebases

* Fixing imports

* Silence the linter

* Make go build happy

(cherry picked from commit ec1072a)

Co-authored-by: Shaunak Kashyap <ycombinator@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v8.7.0 Automated backport with mergify Cleanup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants