-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring fake component and shipper codebases #2378
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ycombinator
requested review from
michalpristas,
pchila and
AndersonQ
and removed request for
a team
March 20, 2023 14:41
6 tasks
ycombinator
commented
Mar 20, 2023
ycombinator
force-pushed
the
refactor-fakes
branch
2 times, most recently
from
March 20, 2023 15:27
19b5046
to
53646be
Compare
AndersonQ
approved these changes
Mar 20, 2023
🌐 Coverage report
|
mergify bot
pushed a commit
that referenced
this pull request
Mar 20, 2023
* Refactoring fake component and shipper codebases * Fixing imports * Silence the linter * Make go build happy (cherry picked from commit ec1072a)
ycombinator
added a commit
that referenced
this pull request
Mar 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR refactors the fake component and shipper codebases, in preparation for #2218.
Why is it important?
To reduce noise in #2218, hopefully making it a bit easier to review.
Checklist
./changelog/fragments
using the changelog toolAuthor's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs