Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Vagrantfile dev box #2454

Merged
merged 1 commit into from
Apr 5, 2023
Merged

Update Vagrantfile dev box #2454

merged 1 commit into from
Apr 5, 2023

Conversation

AndersonQ
Copy link
Member

  • Use latest Ubuntu LTS
  • Change the name to elastic-agent

What does this PR do?

Updates the vagrant dev box

Why is it important?

The current box uses a old ubuntu image and its name is a way too generic

Checklist

  • [ ] My code follows the style guidelines of this project
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] I have added an entry in ./changelog/fragments using the [changelog tool](https://github.com/elastic/elastic-agent#changelog)~~
  • [ ] I have added an integration test or an E2E test

How to test this PR locally

Run
vagrant up elastic-agent

a Vagrant box using virtualbox should start successfully

Use cases

General Elastic Agent development

Questions to ask yourself

  • How are we going to support this in production? N/A
  • How are we going to measure its adoption? N/A
  • How are we going to debug this? N/A
  • What are the metrics I should take care of? N/A

 - Use latest Ubuntu LTS
 - Change the name to elastic-agent
@AndersonQ AndersonQ added enhancement New feature or request backport-v8.7.0 Automated backport with mergify labels Apr 5, 2023
@AndersonQ AndersonQ requested a review from a team as a code owner April 5, 2023 05:04
@AndersonQ AndersonQ self-assigned this Apr 5, 2023
@AndersonQ AndersonQ requested review from blakerouse and michel-laterman and removed request for a team April 5, 2023 05:04
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-04-05T05:05:03.625+0000

  • Duration: 19 min 34 sec

Test stats 🧪

Test Results
Failed 0
Passed 5387
Skipped 23
Total 5410

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages.

  • run integration tests : Run the Elastic Agent Integration tests.

  • run end-to-end tests : Generate the packages and run the E2E Tests.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@elasticmachine
Copy link
Collaborator

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 98.485% (65/66) 👍
Files 69.604% (158/227) 👍
Classes 68.736% (299/435) 👍
Methods 53.915% (909/1686) 👍
Lines 39.061% (10178/26057) 👍 0.035
Conditionals 100.0% (0/0) 💚

Copy link
Contributor

@pierrehilbert pierrehilbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we sure no one is using dev?
Maybe change to have both dev and elastic-agent working would be better?

@AndersonQ AndersonQ merged commit ff0ee71 into main Apr 5, 2023
@AndersonQ AndersonQ deleted the update-vagrantfile branch April 5, 2023 07:19
mergify bot pushed a commit that referenced this pull request Apr 5, 2023
* Use latest Ubuntu LTS
* Change the name to elastic-agent

(cherry picked from commit ff0ee71)

# Conflicts:
#	Vagrantfile
@AndersonQ
Copy link
Member Author

Are we sure no one is using dev? Maybe change to have both dev and elastic-agent working would be better?

The problem with dev is that if another box has got the same name they will conflict.
Someone might be using dev, but then they can just recreate the box, or edit the vagrant file and keep the change local.

From a perspective of a "the recommended way to use vagrant for agent development", using only elastic-agent as the name is better.

AndersonQ pushed a commit that referenced this pull request Apr 5, 2023
* Update Vagrantfile dev box (#2454)

* Use latest Ubuntu LTS
* Change the name to elastic-agent

(cherry picked from commit ff0ee71)
Co-authored-by: Anderson Queiroz <anderson.queiroz@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v8.7.0 Automated backport with mergify enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants