Invalidate host context provider cache when FQDN feature flag is toggled #2461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ycombinator
added
enhancement
ycombinator
requested review from
michel-laterman and
pchila
and removed request for
a team
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. 🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
🌐 Coverage report
|
blakerouse
approved these changes
Apr 6, 2023
| // Update context when any host information changes. | ||
| for { | ||
| t := time.NewTimer(c.CheckInterval) | ||
| select { | ||
| case <-comm.Done(): | ||
| t.Stop() | ||
| features.RemoveFQDNOnChangeCallback(fqdnFeatureFlagCallbackID) | ||
| close(fqdnFFChangeCh) |
There was a problem hiding this comment.
Please move to a defer on line 61 it would be cleaner in the case that a future change results in it not being unregistered.
defer func() {
features.RemoveFQDNOnChangeCallback(fqdnFeatureFlagCallbackID)
close(fqdnFFChangeCh)
}()There was a problem hiding this comment.
Good point, thanks. Done in c008e54.
ycombinator
force-pushed
the
fqdn-host-provider-cache
branch
from
c008e54
to
c48a716
Compare
mergify bot
pushed a commit
that referenced
this pull request
Apr 6, 2023
…led (#2461) * Add callback mechanism to notify when FQDN feature flag is toggled * Use callback to bust host provider cache * Moving const inside method * Fixing typo * Formatting for better readability * Fixing comment * Fixing comment * Check error from features.Apply * Simplify test * Increasing sleep times * Better cleanup of resources (cherry picked from commit 0640efd)
ycombinator
added a commit
that referenced
this pull request
Apr 6, 2023
…led (#2461) (#2469) * Add callback mechanism to notify when FQDN feature flag is toggled * Use callback to bust host provider cache * Moving const inside method * Fixing typo * Formatting for better readability * Fixing comment * Fixing comment * Check error from features.Apply * Simplify test * Increasing sleep times * Better cleanup of resources (cherry picked from commit 0640efd) Co-authored-by: Shaunak Kashyap <ycombinator@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR invalidates the
hostcontext provider's cache whenever the FQDN feature flag is toggled.Why is it important?
With this change, the host context provider will regenerate host information - which includes the hostname / FQDN - whenever the FQDN feature flag is toggled.
Checklist
I have made corresponding changes to the documentationI have made corresponding change to the default configuration filesI have added an entry in./changelog/fragmentsusing the changelog toolI have added an integration test or an E2E testAuthor's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs
Questions to ask yourself