Fix TestRemovePath flakiness on windows #3431
Conversation
pchila
added
bug
|
Pinging @elastic/elastic-agent (Team:Elastic-Agent) |
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. 🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
🌐 Coverage report
|
| } | ||
|
|
||
| time.Sleep(50 * time.Millisecond) |
There was a problem hiding this comment.
I think it might be too much pressure on the OS. But it's a guess. However I think a counter of how many tries happened would be good.
There was a problem hiding this comment.
50 milliseconds is a long time to a computer, this is an improvement over what it did before which was not sleeping.
I'd be in favour of logging how long this function took to complete so we can tell if any future flakiness is just related to marginal timing.
|
buildkite test this |
|
SonarQube Quality Gate
|
Slightly modified the RemovePath retry loop on windows adding another iteration after deleting a blocking executable and introducing a small sleep between attempts. (cherry picked from commit 995b85c)
Slightly modified the RemovePath retry loop on windows adding another iteration after deleting a blocking executable and introducing a small sleep between attempts. (cherry picked from commit 995b85c) Co-authored-by: Paolo Chilà <paolo.chila@elastic.co>
What does this PR do?
Slightly modified the
RemovePathretry loop on windows adding another iteration after deleting a blocking executable.Why is it important?
We want to make sure that we can uninstall elastic-agent even if a binary is still executing within the directory but we want to avoid false positives
Checklist
[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files[ ] I have added tests that prove my fix is effective or that my feature works[ ] I have added an entry in./changelog/fragmentsusing the changelog tool[ ] I have added an integration test or an E2E testAuthor's Checklist
How to test this PR locally
Just run the test on windows (multiple times would be ideal) like:
gotestsum -- -count 1000 -v -run '^TestRemovePath$' github.com/elastic/elastic-agent/internal/pkg/agent/install/Related issues
Use cases
Screenshots
Logs
Questions to ask yourself