Replace timer with ticker in download progress reporter #3548
Conversation
ycombinator
added
Team:Elastic-Agent
|
Pinging @elastic/elastic-agent (Team:Elastic-Agent) |
| @@ -223,7 +227,6 @@ func (e *Downloader) downloadFile(ctx context.Context, artifactName, filename, f | |||
| type downloadProgressReporter struct { | |||
| log progressLogger | |||
| sourceURI string | |||
| timeout time.Duration | |||
There was a problem hiding this comment.
This change is unrelated to this PR per se. But I noticed while working on this PR that this field was never being used, so I'm deleting it as part of this PR.
| @@ -75,11 +75,11 @@ func TestDownloadBodyError(t *testing.T) { | |||
| } | |||
|
|
|||
| func TestDownloadLogProgressWithLength(t *testing.T) { | |||
| fileSize := 100 * units.MiB | |||
| fileSize := 100 * units.MB | |||
There was a problem hiding this comment.
This is just to make the math easier.
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. 🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
🌐 Coverage report
|
ycombinator
force-pushed
the
bugfix-upgrade-progress-reporter
branch
from
64d234a
to
adb0a13
Compare
|
SonarQube Quality Gate
|
* Replace timer with ticker in download progress reporter * Adding CHANGELOG entry * Refactoring: extracting common code into helper function (cherry picked from commit 1c5010f)
* Replace timer with ticker in download progress reporter * Adding CHANGELOG entry * Refactoring: extracting common code into helper function (cherry picked from commit 1c5010f) Co-authored-by: Shaunak Kashyap <ycombinator@gmail.com>
What does this PR do?
This PR fixes a bug in the progress logger being used while downloading the Agent artifact during the upgrade process. Prior to this PR the progress logger used a
time.Timerto log progress of the download. With this PR, the progress logger uses atime.Tickerinstead.Why is it important?
The progress logger should periodically log progress of the download, not just once (after a delay).
Checklist
I have made corresponding changes to the documentationI have made corresponding change to the default configuration files./changelog/fragmentsusing the changelog toolI have added an integration test or an E2E testRelated issues