Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal/pkg/agent/application/coordinator: fix logging calls #3679

Merged
merged 2 commits into from
Nov 15, 2023

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Nov 1, 2023

What does this PR do?

Fixes logging calls that expect to be able to interpret formatting verbs.

Why is it important?

Current code is incorrect.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

Questions to ask yourself

  • How are we going to support this in production?
  • How are we going to measure its adoption?
  • How are we going to debug this?
  • What are the metrics I should take care of?
  • ...

@efd6 efd6 added bug Something isn't working 8.12-candidate backport-v8.11.0 labels Nov 1, 2023
@efd6 efd6 self-assigned this Nov 1, 2023
@efd6 efd6 requested a review from a team as a code owner November 1, 2023 02:52
@elasticmachine
Copy link
Collaborator

elasticmachine commented Nov 1, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-11-14T22:11:30.172+0000

  • Duration: 14 min 55 sec

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages.

  • run integration tests : Run the Elastic Agent Integration tests.

  • run end-to-end tests : Generate the packages and run the E2E Tests.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent (Team:Elastic-Agent)

Copy link
Contributor

@blakerouse blakerouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@blakerouse
Copy link
Contributor

buildkite test this

@blakerouse blakerouse enabled auto-merge (squash) November 1, 2023 13:45
@efd6
Copy link
Contributor Author

efd6 commented Nov 11, 2023

@blakerouse Are you able to force merge this? The integration tests are failing for unrelated reasons.

@cmacknz
Copy link
Member

cmacknz commented Nov 14, 2023

@Mergifyio update

Copy link
Contributor

mergify bot commented Nov 14, 2023

update

✅ Branch has been successfully updated

Copy link

@cmacknz
Copy link
Member

cmacknz commented Nov 15, 2023

Merging, seems like the Windows tests aborted themselves without explanation, I do see the Linux tests passed.

2023-11-14 23:27:48 UTC | >>> (linux-amd64-ubuntu-2204) Test output (sudo) (stdout): >> go test: remote-linux-amd64-ubuntu-2204-sudo.integration Test Passed
-- | --
  | 2023-11-15 03:24:36 UTC | >>> (windows-amd64-2022) non-sudo tests failed: wait: remote command exited without exit status or exit signal
  | 2023-11-15 03:24:36 UTC | >>> (windows-amd64-2022) Failed to execute tests on instance: error running non-sudo tests: failed to fetched test output at %home%\agent\build\TEST-go-remote-windows-amd64-2022.integration.out

@cmacknz cmacknz merged commit 91c03aa into elastic:main Nov 15, 2023
11 of 12 checks passed
mergify bot pushed a commit that referenced this pull request Nov 15, 2023
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
(cherry picked from commit 91c03aa)
belimawr pushed a commit to belimawr/elastic-agent that referenced this pull request Nov 28, 2023
…c#3679) (elastic#3774)

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
(cherry picked from commit 91c03aa)

Co-authored-by: Dan Kortschak <90160302+efd6@users.noreply.github.com>
Co-authored-by: Pierre HILBERT <pierre.hilbert@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.12-candidate backport-v8.11.0 bug Something isn't working Team:Elastic-Agent Label for the Agent team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants