Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue with log_writer panic on line with all spaces #4910

Merged
merged 4 commits into from
Jun 12, 2024
Merged

Fix issue with log_writer panic on line with all spaces #4910

merged 4 commits into from
Jun 12, 2024

Conversation

blakerouse
Copy link
Contributor

@blakerouse blakerouse commented Jun 11, 2024 •
edited
Loading

What does this PR do?

Fixes an issue where the log_writer.go can panic in the case it hits a line that is all spaces that becomes empty.

Why is it important?

Should not panic and crash.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • [ ] I have added an integration test or an E2E test

Related issues

@blakerouse blakerouse added Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team backport-v8.14.0 labels Jun 11, 2024
@blakerouse blakerouse self-assigned this Jun 11, 2024
@blakerouse blakerouse requested a review from a team as a code owner June 11, 2024 20:32
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

jlind23
jlind23 approved these changes Jun 12, 2024
View reviewed changes
Copy link
Contributor

@jlind23 jlind23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this change.

changelog/fragments/1718138001-Fix-possible-crash-in-reading-component-logs.yaml Outdated Show resolved Hide resolved
changelog/fragments/1718138001-Fix-possible-crash-in-reading-component-logs.yaml Outdated Show resolved Hide resolved
changelog/fragments/1718138001-Fix-possible-crash-in-reading-component-logs.yaml Outdated Show resolved Hide resolved
@blakerouse @jlind23
Apply suggestions from code review
b28b3a7 
Co-authored-by: Julien Lind <julien.lind@elastic.co>
@blakerouse blakerouse enabled auto-merge (squash) June 12, 2024 13:21
@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate passed Quality Gate passed

Issues
1 New issue
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@blakerouse blakerouse merged commit 3df9f8b into elastic:main Jun 12, 2024
14 checks passed
mergify bot pushed a commit that referenced this pull request Jun 12, 2024
@blakerouse @mergify
Fix issue with log_writer panic on line with all spaces (#4910)
6902a24 
* Fix #4907.

* Add changelog.

* Apply suggestions from code review

Co-authored-by: Julien Lind <julien.lind@elastic.co>

---------

Co-authored-by: Julien Lind <julien.lind@elastic.co>
(cherry picked from commit 3df9f8b)
@mergify mergify bot mentioned this pull request Jun 12, 2024
Merged
4 tasks
@blakerouse blakerouse deleted the fix-4907 branch June 12, 2024 17:45
blakerouse added a commit that referenced this pull request Jun 12, 2024
@mergify @blakerouse
Fix issue with log_writer panic on line with all spaces (#4910) (#4915)
5d35e16 
* Fix #4907.

* Add changelog.

* Apply suggestions from code review

Co-authored-by: Julien Lind <julien.lind@elastic.co>

---------

Co-authored-by: Julien Lind <julien.lind@elastic.co>
(cherry picked from commit 3df9f8b)

Co-authored-by: Blake Rouse <blake.rouse@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlind23 jlind23 jlind23 approved these changes

@michalpristas michalpristas Awaiting requested review from michalpristas michalpristas is a code owner automatically assigned from elastic/elastic-agent-control-plane

@andrzej-stencel andrzej-stencel Awaiting requested review from andrzej-stencel andrzej-stencel is a code owner automatically assigned from elastic/elastic-agent-control-plane

Assignees

@blakerouse blakerouse

Labels
backport-v8.14.0 Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

crash when logging empty line
3 participants
@blakerouse @elasticmachine @jlind23