-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(tooltip): fix tooltip formatting for rotated charts #285
fix(tooltip): fix tooltip formatting for rotated charts #285
Conversation
When using rotated charts, the used X and Y axis for formatting should be inverted. fix elastic#273
Codecov Report
@@ Coverage Diff @@
## master #285 +/- ##
==========================================
+ Coverage 98.05% 98.16% +0.11%
==========================================
Files 37 37
Lines 2671 2673 +2
Branches 613 615 +2
==========================================
+ Hits 2619 2624 +5
+ Misses 47 44 -3
Partials 5 5
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally, looks good to me! 👍
🎉 This PR is included in version 8.1.8 🎉 The release is available on: Your semantic-release bot 📦🚀 |
## [8.1.8](elastic/elastic-charts@v8.1.7...v8.1.8) (2019-08-05) ### Bug Fixes * **tooltip:** fix tooltip formatting for rotated charts ([opensearch-project#285](elastic/elastic-charts#285)) ([876170d](elastic/elastic-charts@876170d)), closes [opensearch-project#273](elastic/elastic-charts#273)
Summary
When using rotated charts, the used X and Y axis for formatting should be inverted.
fix #273
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.[ ] Any consumer-facing exports were added tosrc/index.ts
(and stories only import from../src
except for test data & storybook)[ ] This was checked for cross-browser compatibility, including a check against IE11[ ] Proper documentation or storybook story was added for features that require explanation or tutorials