Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display orphan data points on line/area series #63

Closed
1 of 3 tasks
markov00 opened this issue Feb 19, 2019 · 2 comments · Fixed by #114 or #900
Closed
1 of 3 tasks

Display orphan data points on line/area series #63

markov00 opened this issue Feb 19, 2019 · 2 comments · Fixed by #114 or #900
Assignees
@markov00
Labels
:chart Chart element related issue enhancement New feature or request released Issue released publicly

Comments

@markov00
Copy link
Member

markov00 commented Feb 19, 2019 •
edited
Loading

Is your feature request related to a problem? Please describe.
Some series may have orphan data points, points that are between two null datums like:

[
   ...,
   {x: 1, y: null},
   {x: 2, y: 10},
   {x: 3, y: null},
   ...,
]

When a series has orphan data points like the example above, we need to find a way to display the single point value.

Fitting functions (#55) can fill the gaps with specific values (like adding zeros or an average value), but the developer or user can decide to keep null values.

Describe the solution you'd like
If the style of the line/area already shows single circles as data points we don't need to add anything to that rendering.

If the style configuration hides the data points we need to force displaying these points when orphans.

We also have to configure the line/area path generation defined function to correctly specify when a line/area is not defined: https://github.com/d3/d3-shape#line_defined https://github.com/d3/d3-shape#area_defined

Kibana Cross Issues
Add any Kibana related issues/feature requests here.

Checklist

  • this request is checked against already exist requests
  • every related Kibana issue is listed under Kibana Cross Issues list
  • kibana cross issue tag is associated to the issue if any kibana cross issue is present
@markov00 markov00 added the enhancement New feature or request label Feb 19, 2019
This was referenced Feb 19, 2019
Closed
Closed
Closed
@markov00 markov00 changed the title Display orphan data points on line/area series [chart] Display orphan data points on line/area series Feb 28, 2019
@markov00 markov00 added this to the 7.1 milestone Feb 28, 2019
@markov00 markov00 added the :chart Chart element related issue label Feb 28, 2019
@markov00 markov00 changed the title [chart] Display orphan data points on line/area series Display orphan data points on line/area series Feb 28, 2019
@markov00 markov00 self-assigned this Mar 22, 2019
markov00 added a commit to markov00/elastic-charts that referenced this issue Mar 22, 2019
@markov00
fix(rendering): fix rendering values <= 0 on log scale
1b8285b 
instead of throwing errors or warnings, if the user is using a log scale with a dataset with 0
values, we will hide them on the rendering of line and area charts. This fix also the defined area
of the chart

fix elastic#112, fix elastic#63
@markov00 markov00 mentioned this issue Mar 22, 2019
Merged
4 tasks
markov00 added a commit that referenced this issue Mar 26, 2019
@markov00
fix(rendering): fix rendering values <= 0 on log scale (#114)
9d7b159 
Instead of throwing errors or warnings, if the user is using a log scale with a dataset with 0
values, we will hide them on the rendering of line and area charts. This fix also the defined area
of the chart

fix #112, fix #63
markov00 pushed a commit that referenced this issue Mar 26, 2019
@semantic-release-bot
chore(release): 3.4.2 [skip ci]
413e2e5 
## [3.4.2](v3.4.1...v3.4.2) (2019-03-26)

### Bug Fixes

* **rendering:** fix rendering values <= 0 on log scale ([#114](#114)) ([9d7b159](9d7b159)), closes [#112](#112) [#63](#63)
@markov00
Copy link
Member Author

🎉 This issue has been resolved in version 3.4.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@markov00 markov00 added the released Issue released publicly label Mar 26, 2019
@markov00 markov00 mentioned this issue Aug 13, 2020
Closed
This was referenced Nov 10, 2020
Merged
Merged
@markov00
Copy link
Member Author

🎉 This issue has been resolved in version 24.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

AMoo-Miki pushed a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this issue Feb 10, 2022
@semantic-release-bot
chore(release): 3.4.2 [skip ci]
6ff06fc 
## [3.4.2](elastic/elastic-charts@v3.4.1...v3.4.2) (2019-03-26)

### Bug Fixes

* **rendering:** fix rendering values <= 0 on log scale ([opensearch-project#114](elastic/elastic-charts#114)) ([2b79877](elastic/elastic-charts@2b79877)), closes [opensearch-project#112](elastic/elastic-charts#112) [opensearch-project#63](elastic/elastic-charts#63)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@markov00 markov00

Labels
:chart Chart element related issue enhancement New feature or request released Issue released publicly
Projects
None yet
Milestone
No milestone
2 participants
@emmacunningham @markov00