Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Interpolate paths for line animations #89

Closed
3 tasks done
emmacunningham opened this issue Mar 1, 2019 · 1 comment · Fixed by #164
Closed
3 tasks done

Interpolate paths for line animations #89

emmacunningham opened this issue Mar 1, 2019 · 1 comment · Fixed by #164
Labels
:chart Chart element related issue enhancement New feature or request released Issue released publicly

Comments

@emmacunningham
Copy link
Contributor

emmacunningham commented Mar 1, 2019 •
edited
Loading

Is your feature request related to a problem? Please describe.
The current implementation of the line chart (see line_geometries.tsx) does not interpolate the paths for the animation. Curved paths are not animated and also this causes an error when showing/hiding a line associated with a series (see #51 (comment))

See pmndrs/react-spring#77

Describe the solution you'd like
Custom interpolation function to handle line animations

Describe alternatives you've considered
It's possible that we don't want to animate the line paths and choose to animate a different property of the line chart.

Additional context

Kibana Cross Issues
n/a

Checklist

  • this request is checked against already exist requests
  • every related Kibana issue is listed under Kibana Cross Issues list
  • kibana cross issue tag is associated to the issue if any kibana cross issue is present
@emmacunningham emmacunningham added the enhancement New feature or request label Mar 1, 2019
@emmacunningham emmacunningham mentioned this issue Mar 1, 2019
Merged
4 tasks
@emmacunningham emmacunningham added the :chart Chart element related issue label Mar 1, 2019
@markov00 markov00 mentioned this issue Mar 27, 2019
Closed
2 tasks
@markov00 markov00 mentioned this issue Apr 10, 2019
Closed
markov00 added a commit to markov00/elastic-charts that referenced this issue Apr 11, 2019
@markov00
fix: temporary disable animation
2898ff4 
Disable animations for all charts until we fix elastic#89 and elastic#41 and until we found a right strategy for
animate everything nicely and at 60fps.

fix elastic#161
@markov00 markov00 mentioned this issue Apr 11, 2019
Merged
1 task
markov00 added a commit that referenced this issue Apr 11, 2019
@markov00
fix: temporary disable animation (#164)
80b3231 
Disable animations for all charts until we fix #89 and #41 and until we found a right strategy for
animate everything nicely and at 60fps.

fix #161
markov00 pushed a commit that referenced this issue Apr 11, 2019
@semantic-release-bot
chore(release): 3.10.1 [skip ci]
3d0a897 
## [3.10.1](v3.10.0...v3.10.1) (2019-04-11)

### Bug Fixes

* temporary disable animation ([#164](#164)) ([80b3231](80b3231)), closes [#89](#89) [#41](#41) [#161](#161)
* temporary disable animation ([#164](#164)) ([c53c8a6](c53c8a6)), closes [#89](#89) [#41](#41) [#161](#161)
@markov00
Copy link
Member

🎉 This issue has been resolved in version 3.10.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@markov00 markov00 added the released Issue released publicly label Apr 11, 2019
emmacunningham pushed a commit to emmacunningham/elastic-charts that referenced this issue Apr 11, 2019
@markov00
fix: temporary disable animation (elastic#164)
c53c8a6 
Disable animations for all charts until we fix elastic#89 and elastic#41 and until we found a right strategy for
animate everything nicely and at 60fps.

fix elastic#161
AMoo-Miki pushed a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this issue Feb 10, 2022
@semantic-release-bot
chore(release): 3.10.1 [skip ci]
6b3f056 
## [3.10.1](elastic/elastic-charts@v3.10.0...v3.10.1) (2019-04-11)

### Bug Fixes

* temporary disable animation ([opensearch-project#164](elastic/elastic-charts#164)) ([0d12878](elastic/elastic-charts@0d12878)), closes [opensearch-project#89](elastic/elastic-charts#89) [opensearch-project#41](elastic/elastic-charts#41) [opensearch-project#161](elastic/elastic-charts#161)
* temporary disable animation ([opensearch-project#164](elastic/elastic-charts#164)) ([76ab583](elastic/elastic-charts@76ab583)), closes [opensearch-project#89](elastic/elastic-charts#89) [opensearch-project#41](elastic/elastic-charts#41) [opensearch-project#161](elastic/elastic-charts#161)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
:chart Chart element related issue enhancement New feature or request released Issue released publicly
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: temporary disable animation markov00/elastic-charts
2 participants
@emmacunningham @markov00