Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RENAME] Refactored Src/core/server/http,http_resources,legacy #89

Merged
merged 6 commits into from
Mar 12, 2021
Merged

[RENAME] Refactored Src/core/server/http,http_resources,legacy #89

merged 6 commits into from
Mar 12, 2021

Conversation

mihirsoni
Copy link
Contributor

Issue #, if available:

Description of changes: Refactored Src/core/server/http,http_resources,legacy

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@mihirsoni
[Rename] Refactored src/plugins/http directory
bc604a2 
Signed-off-by: Mihir Soni <mihirsoni.123@gmail.com>
@mihirsoni
[Rename] Refactored src/plugins/http_resources directory
346d3ae 
Signed-off-by: Mihir Soni <mihirsoni.123@gmail.com>
@mihirsoni
[Rename] Refactored src/plugins/legacy directory
91ed742 
Signed-off-by: Mihir Soni <mihirsoni.123@gmail.com>
kavilla
kavilla reviewed Mar 8, 2021
View reviewed changes
Copy link
Member

@kavilla kavilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some references of kibana still but that should be an easy fix and one mocked import that I think should be reverted.

src/core/server/http/http_server.mocks.ts Outdated
@@ -46,8 +46,8 @@ interface RequestFixtureOptions<P = any, Q = any, B = any> {
method?: RouteMethod;
socket?: Socket;
routeTags?: string[];
kibanaRouteOptions?: KibanaRouteOptions;
kibanaRequestState?: KibanaRequestState;
kibanaRouteOptions?: OpenSearchDashboardsRouteOptions;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kibana

src/core/server/http/http_server.mocks.ts Outdated
kibanaRouteOptions?: KibanaRouteOptions;
kibanaRequestState?: KibanaRequestState;
kibanaRouteOptions?: OpenSearchDashboardsRouteOptions;
kibanaRequestState?: OpenSearchDashboardsRequestState;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kibana

src/core/server/http/http_server.ts Outdated
@@ -178,7 +178,7 @@ export class HttpServer {
const { authRequired, tags, body = {}, timeout } = route.options;
const { accepts: allow, maxBytes, output, parse } = body;

const kibanaRouteOptions: KibanaRouteOptions = {
const kibanaRouteOptions: OpenSearchDashboardsRouteOptions = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kibana

src/core/server/http/index.ts Outdated
@@ -45,7 +45,7 @@ export {
ResponseErrorAttributes,
ResponseHeaders,
kibanaResponseFactory,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was this originally a typo from the author? can it be removed?

src/core/server/http/integration_tests/core_service.test.mocks.ts Outdated Show resolved Hide resolved
src/core/server/http/router/request.test.ts Outdated Show resolved Hide resolved
src/core/server/http/router/request.test.ts Outdated Show resolved Hide resolved
src/core/server/http/router/response_adapter.ts Outdated Show resolved Hide resolved
src/core/server/http/router/router.ts Outdated Show resolved Hide resolved
src/core/server/http/router/router.ts Outdated Show resolved Hide resolved
boktorbb
boktorbb suggested changes Mar 11, 2021
View reviewed changes
Copy link
Contributor

@boktorbb boktorbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to fix all headers

src/core/server/http/auth_headers_storage.test.ts Outdated Show resolved Hide resolved
src/core/server/http/auth_headers_storage.test.ts Outdated Show resolved Hide resolved
src/core/server/http/auth_headers_storage.ts Outdated Show resolved Hide resolved
src/core/server/http/auth_headers_storage.ts Outdated Show resolved Hide resolved
src/core/server/http/auth_state_storage.ts Outdated Show resolved Hide resolved
src/core/server/http/auth_state_storage.ts Outdated Show resolved Hide resolved
src/core/server/http/base_path_proxy_server.ts Outdated Show resolved Hide resolved
src/core/server/http/base_path_proxy_server.ts Outdated Show resolved Hide resolved
src/core/server/http/base_path_service.test.ts Outdated Show resolved Hide resolved
src/core/server/http/base_path_service.test.ts Outdated Show resolved Hide resolved
boktorbb
boktorbb approved these changes Mar 12, 2021
View reviewed changes
Copy link
Contributor

@boktorbb boktorbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kavilla kavilla self-requested a review March 12, 2021 19:21
kavilla
kavilla approved these changes Mar 12, 2021
View reviewed changes
Copy link
Member

@kavilla kavilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks~

@kavilla kavilla merged commit 5956da0 into opensearch-project:dashboards Mar 12, 2021
kavilla referenced this pull request in kavilla/OpenSearch-Dashboards Mar 19, 2021
@mihirsoni @kavilla
[RENAME] Refactored Src/core/server/http,http_resources,legacy (#89)
36a1a02 
* [Rename] Refactored src/plugins/http directory

Signed-off-by: Mihir Soni <mihirsoni.123@gmail.com>

* [Rename] Refactored src/plugins/http_resources directory

Signed-off-by: Mihir Soni <mihirsoni.123@gmail.com>

* [Rename] Refactored src/plugins/legacy directory

Signed-off-by: Mihir Soni <mihirsoni.123@gmail.com>

* [Rename] addressed review feedbacks http directory

* [Rename] addressed review feedbacks http_resoruce and legacy

* [Rename] addressed review feedbacks
kavilla pushed a commit that referenced this pull request Mar 20, 2021
@mihirsoni @kavilla
[RENAME] Refactored Src/core/server/http,http_resources,legacy (#89)
566c7cf 
* [Rename] Refactored src/plugins/http directory

Signed-off-by: Mihir Soni <mihirsoni.123@gmail.com>

* [Rename] Refactored src/plugins/http_resources directory

Signed-off-by: Mihir Soni <mihirsoni.123@gmail.com>

* [Rename] Refactored src/plugins/legacy directory

Signed-off-by: Mihir Soni <mihirsoni.123@gmail.com>

* [Rename] addressed review feedbacks http directory

* [Rename] addressed review feedbacks http_resoruce and legacy

* [Rename] addressed review feedbacks
mihirsoni added a commit that referenced this pull request Mar 20, 2021
@mihirsoni
[RENAME] Refactored Src/core/server/http,http_resources,legacy (#89)
38ed877 
* [Rename] Refactored src/plugins/http directory

Signed-off-by: Mihir Soni <mihirsoni.123@gmail.com>

* [Rename] Refactored src/plugins/http_resources directory

Signed-off-by: Mihir Soni <mihirsoni.123@gmail.com>

* [Rename] Refactored src/plugins/legacy directory

Signed-off-by: Mihir Soni <mihirsoni.123@gmail.com>

* [Rename] addressed review feedbacks http directory

* [Rename] addressed review feedbacks http_resoruce and legacy

* [Rename] addressed review feedbacks
@manasvinibs manasvinibs mentioned this pull request Jul 29, 2022
Merged
7 tasks
Hailong-am pushed a commit to Hailong-am/OpenSearch-Dashboards that referenced this pull request Aug 17, 2023
@yuye-aws
fix: redirect to home only when delete and exit workspace successfully (
d732833 
opensearch-project#89)

* only navigate to home page when delete and exit workspace successfully

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* unsubscribe workspaceEnabled when workspace service stop

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* only hide delete modal when delete workspace successfully

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

---------

Signed-off-by: yuye-aws <yuyezhu@amazon.com>
SuZhou-Joe pushed a commit to SuZhou-Joe/OpenSearch-Dashboards that referenced this pull request Sep 14, 2023
@yuye-aws @SuZhou-Joe
fix: redirect to home only when delete and exit workspace successfully (
14a393d 
opensearch-project#89)

* only navigate to home page when delete and exit workspace successfully

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* unsubscribe workspaceEnabled when workspace service stop

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* only hide delete modal when delete workspace successfully

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

---------

Signed-off-by: yuye-aws <yuyezhu@amazon.com>
Hailong-am pushed a commit to Hailong-am/OpenSearch-Dashboards that referenced this pull request Sep 15, 2023
@yuye-aws @ruanyl
fix: redirect to home only when delete and exit workspace successfully (
89094a4 
opensearch-project#89)

* only navigate to home page when delete and exit workspace successfully

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* unsubscribe workspaceEnabled when workspace service stop

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* only hide delete modal when delete workspace successfully

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

---------

Signed-off-by: yuye-aws <yuyezhu@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kavilla kavilla kavilla approved these changes

@boktorbb boktorbb boktorbb approved these changes

Assignees
No one assigned
Labels
rename
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mihirsoni @kavilla @boktorbb