-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: fix flaky animation story #1804
Conversation
buildkite test this |
buildkite test this |
buildkite test this |
buildkite test this (testing this a bit more) |
buildkite test this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I've run the CI multiple and seems stable
It's strange to me that just setting the |
Summary
Adds
maxDiffPixelRatio
,maxDiffPixels
andthreshold
options to screenshot options and passes to playwrightexpect(element).toMatchSnapshot()
method.Fixes flaky annotation story with minor diff.
Minor diff screenshot below 🧐
Adds retry logic to
exec
helper function to retry processes when needed. This was the suggestion from ops team as they have similar network issues with buildkite agents. This does not fix network issues with commands not usingexec
.Should prevent errors such as...