Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for the "boxplot" aggregation #1412

Closed
wants to merge 6 commits into from
Closed

Add support for the "boxplot" aggregation #1412

wants to merge 6 commits into from

Conversation

hugorodgerbrown
Copy link

@hugorodgerbrown hugorodgerbrown commented Sep 3, 2020

This commit adds a new Agg subclass called BoxPlot, which passes the name "boxplot" as the aggregation type.

See https://www.elastic.co/guide/en/elasticsearch/reference/7.x/search-aggregations-metrics-boxplot-aggregation.html#_syntax

Fixes #1411

This commit adds a new Agg subclass called BoxPlot, which passes the
name "boxplot" as the aggregation type. See https://www.elastic.co/guide/en/elasticsearch/reference/7.x/search-aggregations-metrics-boxplot-aggregation.html#_syntax
@cla-checker-service
Copy link

cla-checker-service bot commented Sep 3, 2020

💚 CLA has been signed

For some reason the cla-checker-service hasn't picked up my CLA, so I'm pushing
a new commit in the hope that it triggers the check again.
Black has updated some rules around how trailing commas are dealt with in wrapping
of lists.
@hugorodgerbrown
Copy link
Author

CI is failing on Black linting - I haven't edited any of the files that are failing, but there has been an update to Black since the last successful build, which may explain it.

@hugorodgerbrown
Copy link
Author

Confirmed - have re-run Black using the latest version.

The standard token filter was a noop in 6.x and has been removed in
7.x
@hugorodgerbrown
Copy link
Author

I have also removed the "standard" token filter from the test_elasticsearch_dsl.test_integration.test_document.snowball analyzer, as it was causing a test failure, and has been removed from ES7.

@hugorodgerbrown
Copy link
Author

Fixed isses in elasticsearch_dsl - CI now failing on building coverage on the nightly build:

  running install_scripts
  Traceback (most recent call last):
    File "<string>", line 1, in <module>
    File "/tmp/pip-wheel-ze049w3s/coverage/setup.py", line 213, in <module>
      main()
    File "/tmp/pip-wheel-ze049w3s/coverage/setup.py", line 203, in main
      setup(**setup_args)
    File "/home/travis/virtualenv/python3.10-dev/lib/python3.10/site-packages/setuptools/__init__.py", line 163, in setup
      return distutils.core.setup(**attrs)
    File "/opt/python/3.10-dev/lib/python3.10/distutils/core.py", line 148, in setup
      dist.run_commands()
    File "/opt/python/3.10-dev/lib/python3.10/distutils/dist.py", line 966, in run_commands
      self.run_command(cmd)
    File "/opt/python/3.10-dev/lib/python3.10/distutils/dist.py", line 985, in run_command
      cmd_obj.run()
    File "/home/travis/virtualenv/python3.10-dev/lib/python3.10/site-packages/wheel/bdist_wheel.py", line 328, in run
      impl_tag, abi_tag, plat_tag = self.get_tag()
    File "/home/travis/virtualenv/python3.10-dev/lib/python3.10/site-packages/wheel/bdist_wheel.py", line 278, in get_tag
      assert tag in supported_tags, "would build wheel with unsupported tag {}".format(tag)
  AssertionError: would build wheel with unsupported tag ('cp310', 'cp310', 'linux_x86_64')

It's curently failing because of a dependency issue in coverage that has nothing
to do with this project.
@hugorodgerbrown
Copy link
Author

hugorodgerbrown commented Sep 3, 2020

I have allowed the "nightly" python build to fail on Travis.

@sethmlarson
Copy link
Contributor

@hugorodgerbrown Thanks for these changes. Could you add the changes to CI / tests to their own PR and keep this only BoxPlot agg so I can backport automatically? :)

@sethmlarson
Copy link
Contributor

Closing this in favor of #1416

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"boxplot" is not available as an aggregation
2 participants