Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting http retries to a negative value no longer retries forever #1178

Closed
jbaiera opened this issue Jul 25, 2018 · 0 comments
Closed

Setting http retries to a negative value no longer retries forever #1178

jbaiera opened this issue Jul 25, 2018 · 0 comments

Comments

@jbaiera
Copy link
Member

jbaiera commented Jul 25, 2018

When we made changes to the underlying mechanisms that support automatically retrying bulk operations, we did not take into account that users may set the system to retry forever. This is currently broken in two places - the HTTP retry handler code only checks that the retries are less than the limit instead of if the limit is below zero, and in the bulk retry loop, were we impose a maximum number of retries to avoid runaway user handlers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant