FIxing WritableBytesConverter to not overwrite bytes with wrong value #2075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes two bugs in
WritableBytesConverter::convert:fromis a BytesWritable then we first correctly copy its bytes totoinSafeWritableConverter, and then we incorrectly copy the bytes for the string representation of the byte array intotoinJdkBytesConverter(so a performance problem plus the wrong data into).fromis a Text then we first correctly copy its bytes totoinSafeWritableConverter, and then we incorrectly copy the string value offrominto a byte array that might be larger than expected inJdkBytesConverter(so a performance problem plus a result array intothat is too large).It looks like this was caused by #937
Closes #2072