public object adapter class, comment (#764) (#765)

Co-authored-by: Laura Trotta <153528055+l-trotta@users.noreply.github.com>
elastic · Mar 14, 2024 · 4854e7d · 4854e7d
1 parent 8e47814
commit 4854e7d
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 4 deletions.
diff --git a/...nt/src/main-flavored/java/co/elastic/clients/elasticsearch/_helpers/esql/EsqlAdapter.java b/...nt/src/main-flavored/java/co/elastic/clients/elasticsearch/_helpers/esql/EsqlAdapter.java
@@ -36,7 +36,7 @@ public interface EsqlAdapter<Result> {
     String format();
 
     /**
-     * For JSON results, whether the result should be organized in rows or columns
+     * For JSON like results, whether the result should be organized in rows or columns
      */
     boolean columnar();
 

diff --git a/...rch/_helpers/esql/ObjectsEsqlAdapter.java → ...pers/esql/objects/ObjectsEsqlAdapter.java b/...rch/_helpers/esql/ObjectsEsqlAdapter.java → ...pers/esql/objects/ObjectsEsqlAdapter.java
@@ -17,9 +17,12 @@
  * under the License.
  */
 
-package co.elastic.clients.elasticsearch._helpers.esql;
+package co.elastic.clients.elasticsearch._helpers.esql.objects;
 
 import co.elastic.clients.ApiClient;
+import co.elastic.clients.elasticsearch._helpers.esql.EsqlAdapter;
+import co.elastic.clients.elasticsearch._helpers.esql.EsqlAdapterBase;
+import co.elastic.clients.elasticsearch._helpers.esql.EsqlMetadata;
 import co.elastic.clients.elasticsearch.esql.QueryRequest;
 import co.elastic.clients.json.BufferingJsonGenerator;
 import co.elastic.clients.json.BufferingJsonpMapper;
@@ -37,7 +40,7 @@
 /**
  * And ES|QL adapter that returns an iterable of domain objects
  */
-class ObjectsEsqlAdapter<T> implements EsqlAdapter<Iterable<T>> {
+public class ObjectsEsqlAdapter<T> implements EsqlAdapter<Iterable<T>> {
 
     public static <T> ObjectsEsqlAdapter<T> of(Class<T> clazz) {
         return new ObjectsEsqlAdapter<>(clazz);
@@ -49,7 +52,7 @@ public static <T> ObjectsEsqlAdapter<T> of(Type type) {
 
     private final Type type;
 
-    ObjectsEsqlAdapter(Type type) {
+    public ObjectsEsqlAdapter(Type type) {
         this.type = type;
     }
 

diff --git a/...src/test/java/co/elastic/clients/elasticsearch/_helpers/esql/EsqlAdapterEndToEndTest.java b/...src/test/java/co/elastic/clients/elasticsearch/_helpers/esql/EsqlAdapterEndToEndTest.java
@@ -23,6 +23,7 @@
 import co.elastic.clients.elasticsearch.ElasticsearchClient;
 import co.elastic.clients.elasticsearch.ElasticsearchTestServer;
 import co.elastic.clients.elasticsearch._helpers.esql.jdbc.ResultSetEsqlAdapter;
+import co.elastic.clients.elasticsearch._helpers.esql.objects.ObjectsEsqlAdapter;
 import co.elastic.clients.json.jackson.JacksonJsonpMapper;
 import co.elastic.clients.transport.rest_client.RestClientTransport;
 import com.fasterxml.jackson.annotation.JsonIgnoreProperties;

diff --git a/...-client/src/test/java/co/elastic/clients/elasticsearch/_helpers/esql/EsqlAdapterTest.java b/...-client/src/test/java/co/elastic/clients/elasticsearch/_helpers/esql/EsqlAdapterTest.java
@@ -21,6 +21,7 @@
 
 import co.elastic.clients.elasticsearch.ElasticsearchClient;
 import co.elastic.clients.elasticsearch._helpers.esql.jdbc.ResultSetEsqlAdapter;
+import co.elastic.clients.elasticsearch._helpers.esql.objects.ObjectsEsqlAdapter;
 import co.elastic.clients.json.jackson.JacksonJsonpMapper;
 import co.elastic.clients.testkit.MockHttpClient;
 import co.elastic.clients.transport.endpoints.BinaryResponse;