Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ObjectsEsqlAdapter refactor #764

Merged
merged 1 commit into from
Mar 14, 2024
Merged

ObjectsEsqlAdapter refactor #764

merged 1 commit into from
Mar 14, 2024

Conversation

l-trotta
Copy link
Contributor

No description provided.

@l-trotta l-trotta requested a review from swallez March 14, 2024 15:30
@l-trotta l-trotta changed the title ObjectEsqlAdapter refactor ObjectsEsqlAdapter refactor Mar 14, 2024
swallez
swallez approved these changes Mar 14, 2024
View reviewed changes
Copy link
Member

@swallez swallez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@l-trotta l-trotta merged commit d0f1aad into main Mar 14, 2024
6 checks passed
@l-trotta l-trotta deleted the esql-quick-fix branch March 14, 2024 15:49
github-actions bot pushed a commit that referenced this pull request Mar 14, 2024
@l-trotta @github-actions
public object adapter class, comment (#764)
36c85aa
@github-actions github-actions bot mentioned this pull request Mar 14, 2024
Merged
l-trotta added a commit that referenced this pull request Mar 14, 2024
@github-actions @l-trotta
public object adapter class, comment (#764) (#765)
4854e7d 
Co-authored-by: Laura Trotta <153528055+l-trotta@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swallez swallez swallez approved these changes

Assignees
No one assigned
Labels
backport 8.13
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@l-trotta @swallez