Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intellisense Documentation Links #3915

Closed
Trisped opened this issue Jul 3, 2019 · 6 comments
Closed

Intellisense Documentation Links #3915

Trisped opened this issue Jul 3, 2019 · 6 comments
Assignees

Comments

@Trisped
Copy link

Trisped commented Jul 3, 2019

NEST/Elasticsearch.Net version: 6.7.0

Description of the problem including expected versus actual behavior:
I have run into a few places in the intelisense documenation (C#) where the links are broken. For example, the DeleteIndexAsync method on Nest.ElasticClient states:

The delete index API allows to delete an existing index.
http://www.elasticsearch.org/guide/en/elasticsearch/reference/current/indices-delete-index.html

The link will work if you replace http://www.elasticsearch.org with https://www.elastic.co.
Someone will need to make this change to all instances in the documentation.

@codebrain codebrain self-assigned this Jul 4, 2019
@russcam russcam added v6.8.1 and removed v7.1.0 labels Jul 11, 2019
@codebrain
Copy link
Contributor

Addressed in elastic/elasticsearch#44487

@russcam russcam removed the v6.8.1 label Aug 12, 2019
@russcam
Copy link
Contributor

russcam commented Aug 12, 2019

Removing v6.8.1,v7.2.0 and adding v7.4.0, as the upstream fix will be applied to v7.4.0

@russcam russcam added v7.4.0 and removed v7.2.0 labels Aug 12, 2019
@Trisped
Copy link
Author

Trisped commented Aug 12, 2019

@russcam Does this mean that the intelisense documenation will only be updated from version 7.4 forward? Is it possible to get the older versions updated also? I expect the older versions will be available for a long time so it will have a large impact.

@russcam
Copy link
Contributor

russcam commented Aug 13, 2019

@Trisped I've asked the question on the upstream change. Typically, a change would be backported to a previous major only if there were to be a new release e.g. a new 6.x version. This change probably would not warrant a release of Elasticsearch, but is useful for the client libraries. Another approach that could be proposed is reinstating the redirects from http://www.elasticsearch.org to https://www.elastic.co

@Trisped
Copy link
Author

Trisped commented Aug 13, 2019

@russcam New releases are preferable, but I understand not doing it since it will be a lot of work to re-release each version. The redirect would be a good work around as long as we are sure we did not miss any of the addresses changes.

russcam added a commit that referenced this issue Nov 13, 2019
This commit replaces the remaining links to elasticsearch.org with their elastic.co counterparts.

Closes #3915
@russcam
Copy link
Contributor

russcam commented Nov 13, 2019

I've opened #4220 to address the final bits in the 7.x client.

russcam added a commit that referenced this issue Nov 13, 2019
This commit replaces the remaining links to elasticsearch.org with their elastic.co counterparts.

Closes #3915
russcam added a commit that referenced this issue Nov 13, 2019
This commit replaces the remaining links to elasticsearch.org with their elastic.co counterparts.

Closes #3915

(cherry picked from commit 58e45ca)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants