Stack overflow when using a pinned query

[DavidRouyer]

NEST/Elasticsearch.Net version: 7.7.1

Elasticsearch version: 7.7.0

Description of the problem including expected versus actual behavior:
I'm trying to make a pinned query with NEST but I'm getting a brutal Stack overflow. message

Steps to reproduce:

1. Try to make a simple pinned query:

ElasticClient.SearchAsync<CreatorNewIndex>(
    new SearchDescriptor<CreatorNewIndex>()
            .From(0)
            .Size(25)
            .Source(s => s.Excludes(e => e.Field(f => f.Events)))
            .Query(q => q.Pinned(p => p
                .Organic(o => o.MatchAll())
                .Ids(new[] { "387c2c78-95b1-42f8-a965-e09a73f7cff6" }))))

or

       var body = PostData.Serializable(new SearchDescriptor<CreatorNewIndex>()
            .From(0)
            .Size(25)
            .Source(s => s.Excludes(e => e.Field(f => f.Events)))
            .Query(q => q.Pinned(p => p
                .Organic(o => o.MatchAll())
                .Ids(new[] { "387c2c78-95b1-42f8-a965-e09a73f7cff6" }))));

            return ElasticClient.LowLevel.SearchAsync<BytesResponse>(this.IndexName, body, ctx: cancellationToken);

which is the equivalent of (but this works)

{
    "query": {
        "pinned": {
            "ids": ["387c2c78-95b1-42f8-a965-e09a73f7cff6"],
            "organic": {
            	"match_all": {}
            }
        }
    },
    "from": 0,
    "size": 25,
    "_source": {
        "excludes": [
            "events"
        ]
    }
}

2. NEST crashes with a Stack overflow. message

Expected behavior
NEST should return the response from Elasticsearch

Provide ConnectionSettings (if relevant):

Provide DebugInformation (if relevant):
I don't have any debug information, I can't catch the error and I only have a 'Stack overflow.' message printed in the console before my program abruptly stops.

[russcam]

Thanks for opening @DavidRouyer. This is a bug in the Ids() overloads which we'll fix for the next release. In the meantime, you can use

client.Search<object>(s => s
		.From(0)
		.Size(25)
		.Source(s => s.Excludes(e => e.Field("events")))
		.Query(q => q.Pinned(p => p
			.Organic(o => o.MatchAll())
			.Ids("387c2c78-95b1-42f8-a965-e09a73f7cff6")
		)
	)
);

or

client.Search<object>(s => s
		.From(0)
		.Size(25)
		.Source(s => s.Excludes(e => e.Field("events")))
		.Query(q => q.Pinned(p => p
			.Organic(o => o.MatchAll())
			.Ids(new Id[] { "387c2c78-95b1-42f8-a965-e09a73f7cff6" })
		)
	)
);

[russcam]

opened #4741 to address

[DavidRouyer]

Thank you! I'll do that