Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FiltersAggregation support #1121

Merged
merged 2 commits into from
Dec 10, 2014
Merged

FiltersAggregation support #1121

merged 2 commits into from
Dec 10, 2014

Conversation

radiosterne
Copy link
Contributor

Named and anonymous filters + some tests

@radiosterne radiosterne mentioned this pull request Dec 9, 2014
Closed
@Mpdreamz Mpdreamz merged commit e8c7161 into elastic:develop Dec 10, 2014
Mpdreamz added a commit that referenced this pull request Dec 10, 2014
@Mpdreamz
removed hardcoded values in tests for #1121 and small indendation tou…
004f910 
…chups
@Mpdreamz
Copy link
Member

Awesome awesome work @radiosterne can't stress this enough, highly appreciated 👍

I did some small tweaks to the tests so that the values are not hardcoded and some small indentation touchups.
We use editorconfig to make sure our indentation settings line up see the visual extension. This allows you to have different editor settings per project.

@radiosterne
Copy link
Contributor Author

Thanks for the tip, @Mpdreamz, editorconfig is great!

@amironoff amironoff mentioned this pull request Jan 2, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@radiosterne @Mpdreamz