Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for the kv processor #2578

Merged
merged 2 commits into from Feb 6, 2017
Merged

add support for the kv processor #2578

merged 2 commits into from Feb 6, 2017

Conversation

Mpdreamz
Copy link
Member

@Mpdreamz Mpdreamz commented Feb 5, 2017

No description provided.

Copy link
Contributor

@russcam russcam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments on #2579 😄

Should this be called KVProcessor to align with the docs?

LGTM.

@Mpdreamz
Copy link
Member Author

Mpdreamz commented Feb 6, 2017

I was on the fence with KVProcessor since that would also mean having a KV() on ProcessorsDescriptor which looks a bit iffy :)

lmk if you object we can rename post merge.

@Mpdreamz Mpdreamz merged commit ee18847 into 5.x Feb 6, 2017
@Mpdreamz Mpdreamz deleted the feature/kv-processor branch February 6, 2017 12:51
Mpdreamz added a commit that referenced this pull request Feb 6, 2017
* add support for the kv processor

* add missing file
@Mpdreamz
Copy link
Member Author

Mpdreamz commented Feb 6, 2017

ported to master

@russcam
Copy link
Contributor

russcam commented Feb 7, 2017

I was on the fence with KVProcessor since that would also mean having a KV() on ProcessorsDescriptor which looks a bit iffy :)

yeah, .KV() is a bit funky. I don't have strong opinions about it to be honest 😄 @gmarz ?

@gmarz
Copy link
Contributor

gmarz commented Feb 7, 2017

I'm good with KeyValue 👍

awelburn pushed a commit to Artesian/elasticsearch-net that referenced this pull request Nov 6, 2017
* add support for the kv processor

* add missing file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants