add boundary scanner and max fragment length support to unified highl… #2746
Conversation
…igther as per #elastic/elasticsearch/23431
russcam
changed the title
There was a problem hiding this comment.
Some small things.
I think we should also support fragmenter: https://github.com/elastic/elasticsearch/blob/4863a9cfdf2ca5a2fdb503e5dab9372a0462cd20/core/src/main/java/org/elasticsearch/search/fetch/subphase/highlight/AbstractHighlighterBuilder.java#L68-L68
| @@ -115,5 +148,13 @@ public class HighlightDescriptor<T> : DescriptorBase<HighlightDescriptor<T> ,IHi | |||
| public HighlightDescriptor<T> BoundaryCharacters(string boundaryCharacters) => Assign(a => a.BoundaryChars = boundaryCharacters); | |||
|
|
|||
| public HighlightDescriptor<T> BoundaryMaxSize(int boundaryMaxSize) => Assign(a => a.BoundaryMaxSize = boundaryMaxSize); | |||
There was a problem hiding this comment.
I realise this is not part of the changes here, but it looks like boundary_max_size should be boundary_max_scan:
I think it makes sense to update as part of this PR
There was a problem hiding this comment.
elastic/elasticsearch#1614 we're in good company of making this mistake :)
There was a problem hiding this comment.
added _scan and obsoleted _size
|
Good catch @russcam added support for |
|
++ I think |
…IHighlightField as well
|
@russcam added test and also copied the properties to |
|
ported to |
…igther as per elastic/elasticsearch#23431