Feature/parent deprecation #3022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…upport now handled by
…or descriptor parameters that are generated
* moved requestparameter patching to its own thing, patch common query parameters seperately and started on generating the base classes for request OIS and fluent * cleaned up request generated and moved logic out of it * finished cleaning up request genererated cshtml * generate common query string params on base descriptor clas * generated descriptor arguments now adhere to csharp guidelines and are camel cased * centralized up how field types are calculated. RequestParameters rendered fields as IEnumerable<object> or object, since the highlevel generated code now sets the query strings directly this is no longer neccessary * Centralized how setters for object initializer classes are generated * requests were using DeprecatedInFavor of which was never set, they now use Obsolete * use expression getter and setters * make cat parameters more descriptive * documentation from spec now word wraps around 140 characters * moved generation code to seperate static class * remove nullable type builder as it the source csharp type itself is nullable now always * OCD over generated output spacing
|
@russcam @codebrain merged this one in to not have two large PR's linger for to long |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.