Fix #3244 allow id to be set on non generic DefaultMappingFor() #3346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
russcam
suggested changes
Aug 7, 2018
| /// <summary> | ||
| /// The property for <see cref="ClrType"/> to resolve ids from. | ||
| /// </summary> | ||
| string IdPropertyVerbatim { get; set; } |
There was a problem hiding this comment.
I'm personally not keen on the Verbatim suffix; is this to indicate that the string value will be taken as exactly as is, to infer the Id property? If it is, my personal preference would be to indicate this in XML comments.
There was a problem hiding this comment.
It;s mainly because we already have IdProperty being Expression<Func<TDocument, object>> so we need two properties. Suggestions on a different name?
There was a problem hiding this comment.
OK I see, where IClrTypeMapping<TDocument> implements IClrTypeMapping.
Maybe IdPropertyName, in line with IndexName, TypeName and RelationName?
Mpdreamz
force-pushed
the
feature/id-property-default-mapping-for-non-generic
branch
from
2048115
to
7d855c1
Compare
Mpdreamz
deleted the
feature/id-property-default-mapping-for-non-generic
branch
Mpdreamz
added a commit
that referenced
this pull request
Aug 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.