Fix #3330 Add additional translog properties as per elastic/elasticsearch#28613… #3358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and add properties we weren't mapping
Mpdreamz
changed the title
|
Travis failures look like an intermittent VM bootstrap issue, kicked them off again. |
russcam
approved these changes
Aug 19, 2018
| public long UncommittedSizeInBytes { get; set; } | ||
|
|
||
| [JsonProperty("earliest_last_modified_age")] | ||
| public long EarliestLastModifiedAge { get; set; } |
There was a problem hiding this comment.
Maybe a comment to indicate that this is valid only for Elasticsearch 6.3.0+? (or maybe long?)
| @@ -8,11 +8,23 @@ public class TranslogStats | |||
| [JsonProperty("operations")] | |||
| public long Operations { get; set; } | |||
|
|
|||
| [JsonProperty("uncommitted_operations")] | |||
| public long UncommittedOperations { get; set; } | |||
There was a problem hiding this comment.
slight nit: Should this be an int?
Mpdreamz
added a commit
that referenced
this pull request
Sep 3, 2018
…arch#28613… (#3358) This commit adds additional translog properties as per elastic/elasticsearch#28613 and add properties we weren't mapping
Mpdreamz
added a commit
that referenced
this pull request
Sep 3, 2018
…arch#28613… (#3358) This commit adds additional translog properties as per elastic/elasticsearch#28613 and add properties we weren't mapping
Mpdreamz
added a commit
that referenced
this pull request
Sep 6, 2018
…arch#28613… (#3358) This commit adds additional translog properties as per elastic/elasticsearch#28613 and add properties we weren't mapping (cherry picked from commit 7ff63ab)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… and add properties we weren't mapping
Implements #3330