Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increment count when serialising multiple lifecycle actions. #4218

Merged
merged 2 commits into from Nov 13, 2019
Merged

Increment count when serialising multiple lifecycle actions. #4218

merged 2 commits into from Nov 13, 2019

Conversation

codebrain
Copy link
Contributor

Fixes #4186

Port to master and 7.4

russcam
russcam approved these changes Nov 13, 2019
View reviewed changes
Copy link
Contributor

@russcam russcam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 small nitpick about formatting

src/Tests/Tests/XPack/Ilm/IlmApiTests.cs Outdated
.Actions(ac => ac.ForceMerge(f => f.MaximumNumberOfSegments(1))))
.Delete(w => w.MinimumAge("30d")
.Actions(ac => ac.Delete(f => f)))))
.Policy(p => p.Phases(a => a.Cold(w => w.Actions(ac => ac.Freeze(f => f).SetPriority(f => f.Priority(50))))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

formatting

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Crikey, thats gone very badly wrong! Will fix now.

@russcam russcam merged commit b8318e6 into 7.x Nov 13, 2019
russcam pushed a commit that referenced this pull request Nov 13, 2019
@codebrain @russcam
Increment count when serialising multiple lifecycle actions. (#4218)
94e59e4 
This commit fixes a bug where the count was not incremented when serialising multiple lifecycle actions.

Fixes #4186

(cherry picked from commit b8318e6)
russcam pushed a commit that referenced this pull request Nov 13, 2019
@codebrain @russcam
Increment count when serialising multiple lifecycle actions. (#4218)
404d361 
This commit fixes a bug where the count was not incremented when serialising multiple lifecycle actions.

Fixes #4186

(cherry picked from commit b8318e6)
@russcam
Copy link
Contributor

russcam commented Nov 13, 2019

ported to 7.4 and master

@Mpdreamz Mpdreamz deleted the fix/7.4.1/lifecycle-actions branch February 10, 2020 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@russcam russcam russcam approved these changes

Assignees
No one assigned
Labels
backport main
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@codebrain @russcam