Fix yaml tests not deleting newly defined hidden indices #4447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before we were not deleting system indices only `.ml-*` However this started to become an issue because it left closed indices around. This might be related to .ml indices now being hidden. Warrants more investigation as the new solution deleting all indices all the time is definitely a bit slower
|
Merging this in as |
github-actions bot
pushed a commit
that referenced
this pull request
Feb 24, 2020
* Fix yaml tests not deleting newly defined hidden indices Before we were not deleting system indices only `.ml-*` However this started to become an issue because it left closed indices around. This might be related to .ml indices now being hidden. Warrants more investigation as the new solution deleting all indices all the time is definitely a bit slower * update refresh and delete to include hidden indices
This comment has been minimized.
This comment has been minimized.
Mpdreamz
added a commit
that referenced
this pull request
Feb 24, 2020
* Fix yaml tests not deleting newly defined hidden indices Before we were not deleting system indices only `.ml-*` However this started to become an issue because it left closed indices around. This might be related to .ml indices now being hidden. Warrants more investigation as the new solution deleting all indices all the time is definitely a bit slower * update refresh and delete to include hidden indices (cherry picked from commit 4906f6d)
|
Manually backported to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before we were not deleting system indices only
.ml-*However this started to become an issue because it left closed indices
around. This might be related to .ml indices now being hidden.
Warrants more investigation as the new solution deleting all indices all
the time is definitely a bit slower