Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure async client methods pass through cancellation token #7676

Merged
merged 1 commit into from May 5, 2023
Merged

Ensure async client methods pass through cancellation token #7676

merged 1 commit into from May 5, 2023

Conversation

stevejgordon
Copy link
Contributor

Fixes #7665.

@stevejgordon
Pass ctx for descriptor-based client methods
a39639b 
Fix applied in the generator to ensure we pass along the cancellation token
to DoRequestAsync.
@stevejgordon stevejgordon added bug 8.x Relates to 8.x client version labels May 5, 2023
@stevejgordon stevejgordon merged commit d1bfe35 into main May 5, 2023
31 checks passed
@stevejgordon stevejgordon deleted the bug-7665-client-async-methods-cancellation-token branch May 5, 2023 08:12
@github-actions github-actions bot mentioned this pull request May 5, 2023
Merged
github-actions bot pushed a commit that referenced this pull request May 5, 2023
@stevejgordon @github-actions
Pass ctx for descriptor-based client methods (#7676)
300142d 
Fix applied in the generator to ensure we pass along the cancellation token
to DoRequestAsync.
github-actions bot pushed a commit that referenced this pull request May 5, 2023
@stevejgordon @github-actions
Pass ctx for descriptor-based client methods (#7676)
7ed5da0 
Fix applied in the generator to ensure we pass along the cancellation token
to DoRequestAsync.
This was referenced May 5, 2023
Merged
Merged
github-actions bot pushed a commit that referenced this pull request May 5, 2023
@stevejgordon @github-actions
Pass ctx for descriptor-based client methods (#7676)
b039c27 
Fix applied in the generator to ensure we pass along the cancellation token
to DoRequestAsync.
@github-actions github-actions bot mentioned this pull request May 5, 2023
Merged
github-actions bot pushed a commit that referenced this pull request May 5, 2023
@stevejgordon @github-actions
Pass ctx for descriptor-based client methods (#7676)
4f15fba 
Fix applied in the generator to ensure we pass along the cancellation token
to DoRequestAsync.
@github-actions github-actions bot mentioned this pull request May 5, 2023
Merged
github-actions bot pushed a commit that referenced this pull request May 5, 2023
@stevejgordon @github-actions
Pass ctx for descriptor-based client methods (#7676)
55f4168 
Fix applied in the generator to ensure we pass along the cancellation token
to DoRequestAsync.
@github-actions github-actions bot mentioned this pull request May 5, 2023
Merged
github-actions bot pushed a commit that referenced this pull request May 5, 2023
@stevejgordon @github-actions
Pass ctx for descriptor-based client methods (#7676)
0ef3abb 
Fix applied in the generator to ensure we pass along the cancellation token
to DoRequestAsync.
@github-actions github-actions bot mentioned this pull request May 5, 2023
Merged
github-actions bot pushed a commit that referenced this pull request May 5, 2023
@stevejgordon @github-actions
Pass ctx for descriptor-based client methods (#7676)
b816f5a 
Fix applied in the generator to ensure we pass along the cancellation token
to DoRequestAsync.
stevejgordon added a commit that referenced this pull request May 5, 2023
@github-actions @stevejgordon
Pass ctx for descriptor-based client methods (#7676) (#7677)
8b5be60 
Fix applied in the generator to ensure we pass along the cancellation token
to DoRequestAsync.

Co-authored-by: Steve Gordon <sgordon@hotmail.co.uk>
stevejgordon added a commit that referenced this pull request May 5, 2023
@github-actions @stevejgordon
Pass ctx for descriptor-based client methods (#7676) (#7678)
326ef62 
Fix applied in the generator to ensure we pass along the cancellation token
to DoRequestAsync.

Co-authored-by: Steve Gordon <sgordon@hotmail.co.uk>
stevejgordon added a commit that referenced this pull request May 5, 2023
@github-actions @stevejgordon
Pass ctx for descriptor-based client methods (#7676) (#7679)
827dc5d 
Fix applied in the generator to ensure we pass along the cancellation token
to DoRequestAsync.

Co-authored-by: Steve Gordon <sgordon@hotmail.co.uk>
stevejgordon added a commit that referenced this pull request May 5, 2023
@github-actions @stevejgordon
Pass ctx for descriptor-based client methods (#7676) (#7680)
674a1b9 
Fix applied in the generator to ensure we pass along the cancellation token
to DoRequestAsync.

Co-authored-by: Steve Gordon <sgordon@hotmail.co.uk>
stevejgordon added a commit that referenced this pull request May 5, 2023
@github-actions @stevejgordon
Pass ctx for descriptor-based client methods (#7676) (#7681)
cf3d0b8 
Fix applied in the generator to ensure we pass along the cancellation token
to DoRequestAsync.

Co-authored-by: Steve Gordon <sgordon@hotmail.co.uk>
stevejgordon added a commit that referenced this pull request May 5, 2023
@github-actions @stevejgordon
Pass ctx for descriptor-based client methods (#7676) (#7682)
f8f225a 
Fix applied in the generator to ensure we pass along the cancellation token
to DoRequestAsync.

Co-authored-by: Steve Gordon <sgordon@hotmail.co.uk>
stevejgordon added a commit that referenced this pull request May 5, 2023
@github-actions @stevejgordon
Pass ctx for descriptor-based client methods (#7676) (#7683)
ce38ec1 
Fix applied in the generator to ensure we pass along the cancellation token
to DoRequestAsync.

Co-authored-by: Steve Gordon <sgordon@hotmail.co.uk>
stevejgordon added a commit that referenced this pull request May 5, 2023
@stevejgordon
Pass ctx for descriptor-based client methods (#7676)
0cf34be 
Fix applied in the generator to ensure we pass along the cancellation token
to DoRequestAsync.
stevejgordon added a commit that referenced this pull request May 5, 2023
@stevejgordon
Missing backports for 8.8 (#7685)
4a80281 
* Rename SqlQueryResponse to QueryResponse (#7667)

* Pass ctx for descriptor-based client methods (#7676)

Fix applied in the generator to ensure we pass along the cancellation token
to DoRequestAsync.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.x Relates to 8.x client version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Generated client descriptor overload methods fail to pass cancellation token through to DoRequestAsync
1 participant
@stevejgordon