Fix 6.8.0 release adding missing class alises #1114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for missing class aliases in 6.8
reedy
reviewed
Mar 15, 2021
src/autoload.php
Outdated
| '\Elasticsearch\Endpoints\Snapshot\Repository\Get' => '\Elasticsearch\Endpoints\Snapshot\GetRepository', | ||
| '\Elasticsearch\Endpoints\Snapshot\Repository\Verify' => '\Elasticsearch\Endpoints\Snapshot\VerifyRepository', | ||
| '\Elasticsearch\Endpoints\Source\Get' => '\Elasticsearch\Endpoints\GetSource', | ||
| '\Elasticsearch\Endpoints\Tasks\TasksList' => '\Elasticsearch\Endpoints\Tasks\ListTasks' |
There was a problem hiding this comment.
I note the whitespace changes make this a little harder to review (on GitHub in a browser) :)
There was a problem hiding this comment.
I fixed the indentation.
reedy
approved these changes
Mar 19, 2021
ezimuel
added a commit
that referenced
this pull request
Mar 22, 2021
* Update Transport.php * Fix 6.8.0 release adding missing class alises (#1114) * Fix for #1112 issue. Adding endpoint aliases + IndicesNamespace::getAliases() * Reverted array alias to class in src/autoload.php + added unit tests for missing class aliases in 6.8 * Fixed indentation in src/ autoload.php * Added TransportTest Co-authored-by: Enrico Zimuel <e.zimuel@gmail.com>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #1112 adding the following missing class aliases for 6.7 BC:
Elasticsearch\Endpoints\Indices\Aliases\UpdateElasticsearch\Endpoints\Indices\Exists\TypesElasticsearch\Endpoints\Indices\Field\GetMoreover, it adds a missing function
getAliases()(proxy ofgetAlias()) inElasticsearch\Namespaces\IndicesNamespace.