Allow psr/log 3 #1190
Allow psr/log 3 #1190
Conversation
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
| @@ -32,7 +32,7 @@ class EmptyLogger extends AbstractLogger implements LoggerInterface | |||
| /** | |||
| * {@inheritDoc} | |||
| */ | |||
| public function log($level, $message, array $context = []) | |||
| public function log($level, $message, array $context = []): void | |||
There was a problem hiding this comment.
note that this is BC break, but given the name of the class, I guess it is not meant to be extended.
|
@cronlabspl Can you please remove or hide your comment as it's confusing (see thread). @ezimuel @karyna-tsymbal-atwix @jrodewig Can this PR be merged? Multiple people are now proposing the same change. This change is needed to be able to upgrade to Symfony 6. |
|
This is a duplicate of #1184 and #1187, the latter of which is now closed as an exact duplicate of the former. @franmomu We very much appreciate the extra detail you have added to this issue, but please could you instead collaborate on #1184 (the original issue), rather than opening a new one. This will help to expedite our work in reviewing and merging. Once you have done so, this issue can be closed. |
|
@technige no problem merging that one! I created this one because I was able to run the workflow jobs and the other PRs I thought they were created editing the file from Github directly, so the purpose was in fact to ease the review (avoid approving the workflow, see if the tests passes, make changes, approve again, etc), but as I said no worries at all merging the other one. |
|
This can be closed as it has been merged into #1184 |
There is #1184 and #1187, but it needs a little bit more of work since there are implementations of psr/log.