Skip to content

Commit

Permalink
[EXT] Fixed incorrect name for the testing cluster "number of nodes" …
Browse files Browse the repository at this point in the history
…option in the documentation

Both the readme and the class level docs refer to what I assume is the
old name of the option to configure the number of nodes in the test
cluster. This change addresses the need.

Closes #366
  • Loading branch information
zamith authored and karmi committed Dec 11, 2016
1 parent 5cb8d7e commit 86fba09
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
8 changes: 4 additions & 4 deletions elasticsearch-extensions/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -136,10 +136,10 @@ Start the cluster on specific port, with a specific Elasticsearch version, numbe
require 'elasticsearch/extensions/test/cluster'

Elasticsearch::Extensions::Test::Cluster.start \
cluster_name: "my-testing-cluster",
command: "/usr/local/Cellar/elasticsearch/0.90.10/bin/elasticsearch",
port: 9350,
nodes: 3
cluster_name: "my-testing-cluster",
command: "/usr/local/Cellar/elasticsearch/0.90.10/bin/elasticsearch",
port: 9350,
number_of_nodes: 3

# Starting 3 Elasticsearch nodes.....................
# --------------------------------------------------------------------------------
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@ class Cluster
# Create a new instance of the Cluster class
#
# @option arguments [String] :cluster_name Cluster name (default: `elasticsearch_test`)
# @option arguments [Integer] :nodes Number of desired nodes (default: 2)
# @option arguments [Integer] :number_of_nodes Number of desired nodes (default: 2)
# @option arguments [String] :command Elasticsearch command (default: `elasticsearch`)
# @option arguments [String] :port Starting port number; will be auto-incremented (default: 9250)
# @option arguments [String] :node_name The node name (will be appended with a number)
Expand Down Expand Up @@ -224,7 +224,7 @@ def initialize(arguments={})
# @example Start a cluster with a custom configuration
# Elasticsearch::Extensions::Test::Cluster::Cluster.new(
# cluster_name: 'my-cluster',
# nodes: 3,
# number_of_nodes: 3,
# node_name: 'my-node',
# port: 9350
# ).start
Expand Down

0 comments on commit 86fba09

Please sign in to comment.