Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add wait_for_completion query parameter in the Delete snapshot API #101300

Closed
romain-chanu opened this issue Oct 25, 2023 · 1 comment · Fixed by #109462
Closed

Add wait_for_completion query parameter in the Delete snapshot API #101300

romain-chanu opened this issue Oct 25, 2023 · 1 comment · Fixed by #109462
Assignees
@nicktindall
Labels
:Distributed/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs >enhancement Team:Distributed Meta label for distributed team

Comments

@romain-chanu
Copy link

romain-chanu commented Oct 25, 2023 •
edited
Loading

Description

Impacted versions: Elasticsearch version 7.17.x / 8.10.x

In very large clusters (thousands of searchable snapshots and automated snapshots and very large cluster state), the Delete snapshot API is likely to take several minutes to complete, resulting in a timeout in Kibana Dev Tools.

Unlike the Create snapshot API and the Restore snapshot API, the Delete snapshot API does not provide the wait_for_completion query parameter.

Providing such query parameter will be useful to run the task asynchronously and keep track of the task execution through the returned task ID.
@romain-chanu romain-chanu added >enhancement needs:triage Requires assignment of a team area label :Distributed/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs labels Oct 25, 2023
@elasticsearchmachine elasticsearchmachine added Team:Distributed Meta label for distributed team and removed needs:triage Requires assignment of a team area label labels Oct 25, 2023
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

@ywangd ywangd self-assigned this Oct 26, 2023
@ywangd ywangd removed their assignment Apr 30, 2024
@nicktindall nicktindall mentioned this issue Jun 7, 2024
Merged
nicktindall added a commit to nicktindall/elasticsearch that referenced this issue Jun 7, 2024
@nicktindall
Add wait_for_completion parameter to delete snapshot request
02e3ed9 
Closes elastic#101300
@nicktindall nicktindall self-assigned this Jun 9, 2024
nicktindall added a commit that referenced this issue Jun 15, 2024
@nicktindall
Add wait_for_completion parameter to delete snapshot request (#109462)
cd8b1f9 
Closes #101300
nicktindall added a commit to nicktindall/elasticsearch that referenced this issue Jun 15, 2024
@nicktindall
Add test for LeakTracker
345d94b 
Related to elastic#101300
nicktindall added a commit that referenced this issue Jun 19, 2024
@nicktindall
[TEST] Add test for LeakTracker (#109777)
c8da581 
Related to #101300
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nicktindall nicktindall

Labels
:Distributed/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs >enhancement Team:Distributed Meta label for distributed team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add wait_for_completion parameter to delete snapshot request nicktindall/elasticsearch
4 participants
@nicktindall @ywangd @romain-chanu @elasticsearchmachine