-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TEST] Add test for LeakTracker #109777
Merged
nicktindall
merged 8 commits into
elastic:main
from
nicktindall:feature/101300_add_tests_for_leak_tracker
Jun 19, 2024
Merged
[TEST] Add test for LeakTracker #109777
nicktindall
merged 8 commits into
elastic:main
from
nicktindall:feature/101300_add_tests_for_leak_tracker
Jun 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related to elastic#101300
nicktindall
added
>test
Issues or PRs that are addressing/adding tests
:Distributed/Distributed
A catch all label for anything in the Distributed Area. If you aren't sure, use this one.
labels
Jun 15, 2024
Pinging @elastic/es-distributed (Team:Distributed) |
elasticsearchmachine
added
v8.15.0
Team:Distributed
Meta label for distributed team
labels
Jun 15, 2024
nicktindall
commented
Jun 16, 2024
server/src/test/java/org/elasticsearch/transport/LeakTrackerTests.java
Outdated
Show resolved
Hide resolved
DaveCTurner
approved these changes
Jun 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (one nit)
test/framework/src/main/java/org/elasticsearch/test/ESTestCase.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
:Distributed/Distributed
A catch all label for anything in the Distributed Area. If you aren't sure, use this one.
Team:Distributed
Meta label for distributed team
>test
Issues or PRs that are addressing/adding tests
v8.15.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #108123
Uses
assertLeakDetected
created for testing #109325