Remove cloud.account and cloud.key settings

[dadoonet]

From @dadoonet on February 27, 2015 15:21

cloud.account and cloud.key settings are not documented as we use cloud.aws.access_key and cloud.aws.secret_key settings instead.

We can deprecated those settings in es-1.4 branch and remove them in master.

Copied from original issue: elastic/elasticsearch-cloud-aws#183

[dadoonet]

@imotov WDYT?

[dadoonet]

From @imotov on February 27, 2015 15:35

Personally I like cloud.account and cloud.key more (mostly because they are shorter). But I can see how this can cause some confusion. Not sure.

[dadoonet]

Yeah. If we want to mix within a node azure settings and aws settings (let say backup in two places), I think it's better to prefix setting name.

[dadoonet]

From @kimchy on February 27, 2015 15:43

we do support both, right? I mean, sure, we can simplify and not provide too many options to configure things and be more explicit around the actual aws settings

[dadoonet]

we do support both today. But the simplest form cloud.account is not documented AFAIK.

[dadoonet]

From @nikolay on February 27, 2015 20:17

@imotov With AWS, "account" and "access key" are two different things, so, cloud.account will be misleading.

[xuzha]

Do we still need to discuss about this? If nobody objects, I'm going to merge this change soon.