Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

analyze api accepts "filters" while create index relies on "filter" #15189

Closed
javanna opened this issue Dec 2, 2015 · 5 comments
Closed

analyze api accepts "filters" while create index relies on "filter" #15189

javanna opened this issue Dec 2, 2015 · 5 comments
Assignees
@johtani
Labels
>enhancement good first issue low hanging fruit :Search Relevance/Analysis How text is split into tokens Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch

Comments

@javanna
Copy link
Member

javanna commented Dec 2, 2015

The analyze api seems to accept a filters element, which makes sense, but create index only knows about filter instead (singular) when creating a custom analyzer. Can we make the two consistent?
@javanna javanna added the :Search Relevance/Analysis How text is split into tokens label Dec 2, 2015
@rjernst
Copy link
Member

rjernst commented Dec 2, 2015

+1

1 similar comment
@dakrone
Copy link
Member

dakrone commented Dec 2, 2015

+1

@clintongormley
Copy link

Same goes for char_filters/char_filter.

@johtani want to take a look?

@clintongormley clintongormley removed the help wanted adoptme label Dec 5, 2015
@clintongormley clintongormley mentioned this issue Dec 5, 2015
Closed
@johtani
Copy link
Contributor

johtani commented Dec 28, 2015

I am planning to delete filters/char_filters from _analyze API in master, and deprecated them in 2.x.
Does it make sense?

@clintongormley
Copy link

+1

@javanna javanna mentioned this issue Feb 9, 2016
Closed
This was referenced Apr 19, 2016
Merged
Merged
Closed
johtani added a commit to johtani/elasticsearch that referenced this issue Apr 20, 2016
@johtani
Analysis : Deprecated "filters"/"char_filters" in 2.x
7135492 
Accept "filter"/"char_filter" instead of  "filters"/"char_filters"

Closes elastic#15189
johtani added a commit that referenced this issue Apr 20, 2016
@johtani
Analysis : Deprecated "filters"/"char_filters" in 2.x
9fb8bc6 
Accept "filter"/"char_filter" instead of  "filters"/"char_filters"

Closes #15189
johtani added a commit to johtani/elasticsearch that referenced this issue Apr 21, 2016
@johtani
Analyze API : Rename filters/token_filters/char_filter to filter/toke…
9eb242a 
…n_filter/char_filter

Closes elastic#15189
@javanna javanna added the Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch label Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johtani johtani

Labels
>enhancement good first issue low hanging fruit :Search Relevance/Analysis How text is split into tokens Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@dakrone @clintongormley @rjernst @javanna @johtani