Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Analyze API : Rename filters/token_filters/char_filter in Analyze API in master #17843

Merged

Conversation

johtani
Copy link
Contributor

@johtani johtani commented Apr 19, 2016

Analyze API : Rename filters/token_filters/char_filters to filter/token_filter/char_filter

This PR is for master branch.

Closes #15189

@johtani
Copy link
Contributor Author

johtani commented Apr 19, 2016

@clintongormley I renamed only request params and didn't change response and Java API.
Does it make sense? Or should we change response and Java methods?
What do you think?

@clintongormley
Copy link

LGTM

@clintongormley clintongormley added >breaking :Search Relevance/Analysis How text is split into tokens labels Apr 20, 2016
@johtani johtani force-pushed the fix/change_filters_parameter_in_analyze_api branch from c856c87 to 9eb242a Compare April 21, 2016 09:58
@johtani johtani merged commit 9eb242a into elastic:master Apr 21, 2016
@johtani johtani deleted the fix/change_filters_parameter_in_analyze_api branch August 23, 2016 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants