Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate analyser aliases? #18244

Closed
clintongormley opened this issue May 10, 2016 · 1 comment
Closed

Deprecate analyser aliases? #18244

clintongormley opened this issue May 10, 2016 · 1 comment
Assignees
@abeyad
Labels
>deprecation good first issue low hanging fruit :Search/Analysis How text is split into tokens v5.0.0-beta1

Comments

@clintongormley
Copy link

Does anybody use aliases for analyzers? (https://www.elastic.co/guide/en/elasticsearch/reference/current/analysis-analyzers.html#aliasing-analyzers)

I've never heard of anybody and can't think of a use case. I think they should be deprecated.
@clintongormley clintongormley mentioned this issue May 11, 2016
Merged
clintongormley added a commit to clintongormley/elasticsearch that referenced this issue May 11, 2016
@clintongormley
Docs: First pass at improving analyzer docs
c5e9e12 
I've rewritten the intro to analyzers plus the docs
for all analyzers to provide working examples.

I've also removed:

* analyzer aliases (see elastic#18244)
* analyzer versions (see elastic#18267)
* snowball analyzer (see elastic#8690)

Next steps will be tokenizers, token filters, char filters
clintongormley added a commit that referenced this issue May 11, 2016
@clintongormley
First pass at improving analyzer docs (#18269)
97a41ee 
* Docs: First pass at improving analyzer docs

I've rewritten the intro to analyzers plus the docs
for all analyzers to provide working examples.

I've also removed:

* analyzer aliases (see #18244)
* analyzer versions (see #18267)
* snowball analyzer (see #8690)

Next steps will be tokenizers, token filters, char filters

* Fixed two typos
@s1monw
Copy link
Contributor

s1monw commented Jul 8, 2016

+1 I think we should get rid of this in 6

@abeyad abeyad self-assigned this Aug 11, 2016
@abeyad abeyad removed the help wanted adoptme label Aug 11, 2016
@abeyad abeyad mentioned this issue Aug 15, 2016
Merged
abeyad pushed a commit to abeyad/elasticsearch that referenced this issue Aug 15, 2016
Removes support for adding aliases to analyzers. Indices created pre 5.x
f9e7352 
that have analyzer aliases in their analysis settings will still work, but
any attempts to create an alias for analyzers in newly created indices
will result in an IllegalArgumentException.

As a result, the setting `index.analysis.analyzer.{analyzerName}.alias` is
no longer supported.

Closes elastic#18244
abeyad pushed a commit that referenced this issue Aug 15, 2016
Removes support for adding aliases to analyzers. Indices created pre …
5ba06b6 
…5.x (#19994)

that have analyzer aliases in their analysis settings will still work, but
any attempts to create an alias for analyzers in newly created indices
will result in an IllegalArgumentException.

As a result, the setting `index.analysis.analyzer.{analyzerName}.alias` is
no longer supported.

Closes #18244
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abeyad abeyad

Labels
>deprecation good first issue low hanging fruit :Search/Analysis How text is split into tokens v5.0.0-beta1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@clintongormley @s1monw @abeyad