Removes support for adding aliases to analyzers #19994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abeyad
added
>breaking
review
:Search Relevance/Analysis
abeyad
force-pushed
the
remove-analyzer-alias
branch
from
be5ebe2
to
cd67f79
Compare
| @@ -332,7 +346,8 @@ public void testUnderscoreInAnalyzerNameAlias() throws IOException { | |||
| .put("index.analysis.analyzer.valid_name.tokenizer", "keyword") | |||
| .put("index.analysis.analyzer.valid_name.alias", "_invalid_name") | |||
| .put(Environment.PATH_HOME_SETTING.getKey(), createTempDir().toString()) | |||
| .put(IndexMetaData.SETTING_VERSION_CREATED, "1") | |||
| // analyzer aliases are only allowed for indices created in v5.0 alpha5 or before | |||
| .put(IndexMetaData.SETTING_VERSION_CREATED, VersionUtils.randomVersionBetween(random(), null, Version.V_5_0_0_alpha5)) | |||
There was a problem hiding this comment.
We don't explicitly support upgrading between alphas. Can you test this with a 2.x version instead? I would use VersionUtils.getPreviousVersion(Version.V_5_0_0_alpha1)
|
LGTM |
that have analyzer aliases in their analysis settings will still work, but
any attempts to create an alias for analyzers in newly created indices
will result in an IllegalArgumentException.
As a result, the setting `index.analysis.analyzer.{analyzerName}.alias` is
no longer supported.
Closes elastic#18244
abeyad
force-pushed
the
remove-analyzer-alias
branch
from
cd67f79
to
f9e7352
Compare
|
@rjernst thanks for the review! I changed the tests to pick a random 2.x version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes support for adding aliases to analyzers. Indices created pre 5.x
that have analyzer aliases in their analysis settings will still work, but
any attempts to create an alias for analyzers in newly created indices
will result in an
IllegalArgumentException.As a result, the setting
index.analysis.analyzer.{analyzerName}.aliasisno longer supported.
Note that the documentation for this setting was already removed in #18269.
Closes #18244