Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Other methods of s3 server-side encryption #18561

Closed
tylerfontaine opened this issue May 25, 2016 · 4 comments
Closed

Allow Other methods of s3 server-side encryption #18561

tylerfontaine opened this issue May 25, 2016 · 4 comments
Labels
:Distributed/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs >enhancement help wanted adoptme

Comments

@tylerfontaine
Copy link

Describe the feature:

Currently, by setting server_side_encryption to true, the only method that is allowed is aes256. It would be great if we could specify other s3 encryption methods, e.g. aws:kms.

For aws:kms, if the bucket has a default key, it's just a matter of including the correct header, so one possibility may be an additional parameter to specify the value of the x-amz-server-side-encryption header to get sent with requests. But the ability to specify an ams key to use would also be great.

@dadoonet
Copy link
Member

@smarks
Copy link

smarks commented May 8, 2017

I would like to work on this.

@clintongormley clintongormley added :Distributed/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs and removed :Plugin Cloud AWS labels Feb 14, 2018
@bhchew
Copy link

bhchew commented May 9, 2018

S3 bucket defaut encryption was introduced late 2017,

https://aws.amazon.com/blogs/aws/new-amazon-s3-encryption-security-features/

If kms default encryption is set in the bucket, we can add additonal policy, besides the S3 permissoin to allow encrypt/decrypt using the key.

Can anyone else confirm this?

@original-brownbear
Copy link
Member

Closing here as a duplicate of #41196

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Distributed/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs >enhancement help wanted adoptme
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants