-
Notifications
You must be signed in to change notification settings - Fork 24.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove spaces from commented out config settings #20090
Labels
Comments
I agree that a lot of people are falling into this trap. (Me included when I started my first Elasticsearch:) ) +1 |
abeyad
pushed a commit
to abeyad/elasticsearch
that referenced
this issue
Aug 21, 2016
the setting in elasticsearch.yml, so that when a user uncomments out a setting by just removing the #, the setting actually takes effect. Before, it was very easy to uncomment out a setting by just removing the #, leaving a single whitespace character before the setting name, which would cause the setting to not get picked up by Elasticsearch. Closes elastic#20090
I agree, and it would also bring I've opened a PR for this: #20094 |
abeyad
pushed a commit
that referenced
this issue
Aug 22, 2016
the setting in elasticsearch.yml, so that when a user uncomments out a setting by just removing the #, the setting actually takes effect. Before, it was very easy to uncomment out a setting by just removing the #, leaving a single whitespace character before the setting name, which would cause the setting to not get picked up by Elasticsearch. Closes #20090
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
From time to time a user runs into an issue with ES not starting and it's sometimes because they uncomment a config option in
elasticsearch.yml
but only remove the#
.eg;
# cluster.name: my-application
becomes;
cluster.name: my-application
Note the white space in front (it's hard to see here).
Could we make this simpler for users by just removing that white space between the
#
and the setting? ie;#cluster.name: my-application
The text was updated successfully, but these errors were encountered: