-
Notifications
You must be signed in to change notification settings - Fork 24.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should Deprecation HTTP headers normalize comma in messages #22986
Comments
It is indeed the case that the warning header can be multi-valued which means that we do need to address the comma-separated issue here. On closer inspection of the HTTP spec, we are not following the warning header specification. We should be prepending each warning with a code (we can just use 199 miscellaneous) and an agent (we can just use the Elasticsearch version), and then we should be quoting each warning string to address the comma issue. |
Not entirely sure what the HTTP spec status of response headers is but with request headers
is equivalent to:
Quite a few deprecation messages contain a comma which causes an ambiguity when I get to actually parse these (from .NET BCL in this case.
e.g:
Yields:
Which is impossible to stitch back together as two messages.
The text was updated successfully, but these errors were encountered: