-
Notifications
You must be signed in to change notification settings - Fork 24.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SharedClusterSnapshotRestoreIT times out #23663
Labels
:Distributed/Snapshot/Restore
Anything directly related to the `_snapshot/*` APIs
>test
Issues or PRs that are addressing/adding tests
Comments
abeyad
pushed a commit
to abeyad/elasticsearch
that referenced
this issue
Mar 22, 2017
This commit fixes an issue manifested in the SharedClusterSnapshotRestoreIT#testGetSnapshotsRequest where a delete request on a snapshot encounters an in-progress snapshot, so it first tries to abort the snapshot. During the aborting process, an exception is thrown which is handled by the snapshot listener's onSnapshotFailure method. This method retries the delete snapshot request, only to encounter that the snapshot is missing, throwing an exception. It is possible that the snapshot failure resulted in the snapshot never having been written to the repository, and hence, there is nothing to delete. This commit handles the SnapshotMissingException by logging it and notifying the listener of the missing snapshot. Closes elastic#23663
abeyad
pushed a commit
that referenced
this issue
Mar 23, 2017
) This commit fixes an issue manifested in the SharedClusterSnapshotRestoreIT#testGetSnapshotsRequest where a delete request on a snapshot encounters an in-progress snapshot, so it first tries to abort the snapshot. During the aborting process, an exception is thrown which is handled by the snapshot listener's onSnapshotFailure method. This method retries the delete snapshot request, only to encounter that the snapshot is missing, throwing an exception. It is possible that the snapshot failure resulted in the snapshot never having been written to the repository, and hence, there is nothing to delete. This commit handles the SnapshotMissingException by logging it and notifying the listener of the missing snapshot. Closes #23663
abeyad
pushed a commit
that referenced
this issue
Mar 23, 2017
) This commit fixes an issue manifested in the SharedClusterSnapshotRestoreIT#testGetSnapshotsRequest where a delete request on a snapshot encounters an in-progress snapshot, so it first tries to abort the snapshot. During the aborting process, an exception is thrown which is handled by the snapshot listener's onSnapshotFailure method. This method retries the delete snapshot request, only to encounter that the snapshot is missing, throwing an exception. It is possible that the snapshot failure resulted in the snapshot never having been written to the repository, and hence, there is nothing to delete. This commit handles the SnapshotMissingException by logging it and notifying the listener of the missing snapshot. Closes #23663
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
:Distributed/Snapshot/Restore
Anything directly related to the `_snapshot/*` APIs
>test
Issues or PRs that are addressing/adding tests
See https://elasticsearch-ci.elastic.co/job/elastic+elasticsearch+master+periodic/2158
Reproduction line (which fails to reproduce the issue):
The text was updated successfully, but these errors were encountered: