Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SharedClusterSnapshotRestoreIT times out #23663

Closed
bleskes opened this issue Mar 20, 2017 · 0 comments · Fixed by #23703
Closed

SharedClusterSnapshotRestoreIT times out #23663

bleskes opened this issue Mar 20, 2017 · 0 comments · Fixed by #23703
Assignees
@abeyad
Labels
:Distributed/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs >test Issues or PRs that are addressing/adding tests

Comments

@bleskes
Copy link
Contributor

bleskes commented Mar 20, 2017

See https://elasticsearch-ci.elastic.co/job/elastic+elasticsearch+master+periodic/2158

Reproduction line (which fails to reproduce the issue):

gradle :core:integTest -Dtests.seed=1DA1BF57E52F287A -Dtests.class=org.elasticsearch.snapshots.SharedClusterSnapshotRestoreIT -Dtests.security.manager=true -Dtests.locale=en-US -Dtests.timezone=UTC
@bleskes bleskes added the >test Issues or PRs that are addressing/adding tests label Mar 20, 2017
@colings86 colings86 added the :Distributed/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs label Mar 21, 2017
abeyad pushed a commit to abeyad/elasticsearch that referenced this issue Mar 22, 2017
Fixes snapshot deletion handling on in-progress snapshot failure
c7940c3 
This commit fixes an issue manifested in the
SharedClusterSnapshotRestoreIT#testGetSnapshotsRequest where a delete
request on a snapshot encounters an in-progress snapshot, so it first
tries to abort the snapshot.  During the aborting process, an exception
is thrown which is handled by the snapshot listener's onSnapshotFailure
method.  This method retries the delete snapshot request, only to
encounter that the snapshot is missing, throwing an exception.  It is
possible that the snapshot failure resulted in the snapshot never having
been written to the repository, and hence, there is nothing to delete.
This commit handles the SnapshotMissingException by logging it and
notifying the listener of the missing snapshot.

Closes elastic#23663
@abeyad abeyad mentioned this issue Mar 22, 2017
Merged
abeyad pushed a commit that referenced this issue Mar 23, 2017
Fixes snapshot deletion handling on in-progress snapshot failure (#23703
2df3968 
)

This commit fixes an issue manifested in the
SharedClusterSnapshotRestoreIT#testGetSnapshotsRequest where a delete
request on a snapshot encounters an in-progress snapshot, so it first
tries to abort the snapshot.  During the aborting process, an exception
is thrown which is handled by the snapshot listener's onSnapshotFailure
method.  This method retries the delete snapshot request, only to
encounter that the snapshot is missing, throwing an exception.  It is
possible that the snapshot failure resulted in the snapshot never having
been written to the repository, and hence, there is nothing to delete.
This commit handles the SnapshotMissingException by logging it and
notifying the listener of the missing snapshot.

Closes #23663
abeyad pushed a commit that referenced this issue Mar 23, 2017
Fixes snapshot deletion handling on in-progress snapshot failure (#23703
1325ed3 
)

This commit fixes an issue manifested in the
SharedClusterSnapshotRestoreIT#testGetSnapshotsRequest where a delete
request on a snapshot encounters an in-progress snapshot, so it first
tries to abort the snapshot.  During the aborting process, an exception
is thrown which is handled by the snapshot listener's onSnapshotFailure
method.  This method retries the delete snapshot request, only to
encounter that the snapshot is missing, throwing an exception.  It is
possible that the snapshot failure resulted in the snapshot never having
been written to the repository, and hence, there is nothing to delete.
This commit handles the SnapshotMissingException by logging it and
notifying the listener of the missing snapshot.

Closes #23663
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abeyad abeyad

Labels
:Distributed/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs >test Issues or PRs that are addressing/adding tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes snapshot deletion handling on in-progress snapshot failure abeyad/elasticsearch
3 participants
@colings86 @bleskes @abeyad