Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Percolator] Remove caching and support "now" in range queries #23859

Closed
pickypg opened this issue Mar 31, 2017 · 1 comment
Closed

[Percolator] Remove caching and support "now" in range queries #23859

pickypg opened this issue Mar 31, 2017 · 1 comment
Assignees
@martijnvg
Labels
>enhancement :Search Relevance/Percolator Reverse search: find queries that match a document Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch

Comments

@pickypg
Copy link
Member

pickypg commented Mar 31, 2017

With the changes to Percolator, we began caching the results of Percolated requests, but this prevents the use of now in range queries / filters.

It was decided to disable caching (for many reasons), which will then allow now to be used by the Percolator.
@pickypg pickypg added :Search Relevance/Percolator Reverse search: find queries that match a document >enhancement labels Mar 31, 2017
@pickypg
Copy link
Member Author

pickypg commented Mar 31, 2017

/cc @clintongormley @martijnvg

If this is a dupe, sorry. I couldn't find anything related. Feel free to fix my description of the issue too.

@martijnvg martijnvg mentioned this issue Apr 5, 2017
Merged
martijnvg added a commit that referenced this issue Apr 7, 2017
@martijnvg
[PERCOLATOR] Allowing range queries with now ranges inside percolator…
7bc2477 
… queries.

Before now ranges where forbidden, because the percolator query itself could get cached and then the percolator queries with now ranges that should no longer match, incorrectly will continue to match.
By disabling caching when the `percolator` is being used, the percolator can now correctly support range queries with now based ranges.

 I think this is the right tradeoff. The percolator query is likely to not be the same between search requests and disabling range queries with now ranges really disabled people using the percolator for their use cases.

 Also fixed an issue that existed in the percolator fieldmapper, it was unable to find forbidden queries inside `dismax` queries.

 Closes #23859
@anatoly21 anatoly21 mentioned this issue Apr 14, 2017
Closed
@javanna javanna added the Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch label Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@martijnvg martijnvg

Labels
>enhancement :Search Relevance/Percolator Reverse search: find queries that match a document Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@martijnvg @javanna @pickypg