Allowing range queries with now ranges inside percolator queries #23921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martijnvg
added
:Search Relevance/Percolator
|
Using instance equality is a bit dangerous since the query could still get cached if you run the same query instance multiple times. I think this is an ok risk given that we create new queries everytime, but I think we should have comments about it in the equals/hashCode methods. |
|
@jpountz Agreed. Added the comments. I basically looked at ScriptQuery and saw that we compare it in the same way also to avoid caching. |
… queries. Before now ranges where forbidden, because the percolator query itself could get cached and then the percolator queries with now ranges that should no longer match, incorrectly will continue to match. By disabling caching when the `percolator` is being used, the percolator can now correctly support range queries with now based ranges. I think this is the right tradeoff. The percolator query is likely to not be the same between search requests and disabling range queries with now ranges really disabled people using the percolator for their use cases. Also fixed an issue that existed in the percolator fieldmapper, it was unable to find forbidden queries inside `dismax` queries. Closes elastic#23859
martijnvg
force-pushed
the
percolator_support_now_ranges
branch
from
7507a4a
to
3d9671a
Compare
|
@martijnvg I'm wondering if I should be able to use ranges after this commit, but I'm still getting an IllegalArgumentException https://discuss.elastic.co/t/allowing-range-queries-with-now-ranges-inside-percolator/85696 Any idea what else do I have to do? |
martijnvg
added a commit
to martijnvg/elasticsearch
that referenced
this pull request
May 16, 2017
Range queries with now based date ranges were previously not allowed, but since elastic#23921 these queries were allowed. This change should really fix range queries with now based date ranges.
martijnvg
added a commit
that referenced
this pull request
May 16, 2017
Range queries with now based date ranges were previously not allowed, but since #23921 these queries were allowed. This change should really fix range queries with now based date ranges.
martijnvg
added a commit
that referenced
this pull request
May 16, 2017
Range queries with now based date ranges were previously not allowed, but since #23921 these queries were allowed. This change should really fix range queries with now based date ranges.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before now ranges where forbidden, because the percolator query itself could get cached and then the percolator queries with now ranges that should no longer match, incorrectly will continue to match.
By disabling caching when the
percolatoris being used, the percolator can now correctly support range queries with now based ranges.I think this is the right tradeoff. The percolator query is likely to not be the same between search requests and disabling range queries with now ranges really disabled people using the percolator for some of their use cases.
Also fixed an issue that existed in the percolator fieldmapper, it was unable to find forbidden queries inside
dismaxqueries.PR for #23859