Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove setting index.optimize_auto_generated_id (#27583) #27600

Merged
merged 3 commits into from
Feb 16, 2019

Conversation

liketic
Copy link
Contributor

@liketic liketic commented Nov 30, 2017

Closes #27583

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

Copy link
Member

@jasontedor jasontedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am pretty sure this is not enough. This setting can be on indices created in 6.x and we will support them in 7.x.

@s1monw
Copy link
Contributor

s1monw commented Nov 30, 2017

@jasontedor why can't we remove it? it will just be archived since you never pushed #26995 maybe I miss something

@s1monw
Copy link
Contributor

s1monw commented Nov 30, 2017

@elasticmachine ok to test

@liketic
Copy link
Contributor Author

liketic commented Nov 30, 2017

Thanks for your review. I can address @jasontedor 's comments by deprecating the setting index.optimize_auto_generated_id and reject it for 7.x instead if needed. 👍

@liketic
Copy link
Contributor Author

liketic commented Dec 19, 2017

Hi @jasontedor Shall I update the PR by deprecating the setting? 👍 Thanks very much!

@jasontedor
Copy link
Member

@liketic Yes, here is what we need to do:

  • deprecate in 6.x (one PR)
  • prevent the ability to modify this setting on indices created since 7.0.0 (another PR)
  • remove this setting completely in 8.0.0 (this PR)

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@liketic
Copy link
Contributor Author

liketic commented Mar 1, 2018

Thanks @jasontedor . I opened #28862 for the first one.

@liketic
Copy link
Contributor Author

liketic commented Mar 4, 2018

And #28895 for the second one.

@jasontedor
Copy link
Member

@liketic Now that 7.0 and 7.x are branched from master and #28895 is integrated, we can get this change in. Can you bring this change up to date with the master branch?

@liketic
Copy link
Contributor Author

liketic commented Feb 12, 2019

@jasontedor Please review again.

@jasontedor
Copy link
Member

@elasticmachine test this please

Copy link
Member

@jasontedor jasontedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jasontedor jasontedor merged commit 5a58c9e into elastic:master Feb 16, 2019
@jasontedor
Copy link
Member

Thanks @liketic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove index.optimize_auto_generated_id
7 participants