[test failure] :x-pack:plugin:watcher:test can fail with java.lang.IllegalArgumentException: Both text and attachments cannot be null. #31948

jakelandis · 2018-07-11T02:04:38Z

I ran into this on an unrelated PR on the master branch, and can reliably reproduce.

ERROR   0.22s | SlackMessageTests.testTemplateRender <<< FAILURES!
   > Throwable #1: java.lang.IllegalArgumentException: Both text and attachments cannot be null.
   >    at __randomizedtesting.SeedInfo.seed([7E16EC5523F952E7:5C93EBB62B66EC8]:0)

Reproduce:

./gradlew :x-pack:plugin:watcher:test -Dtests.seed=7E16EC5523F952E7 -Dtests.class=org.elasticsearch.xpack.watcher.notification.slack.message.SlackMessageTests -Dtests.method="testTemplateRender" -Dtests.security.manager=true -Dtests.locale=hr -Dtests.timezone=Asia/Omsk

Recent relevant change: 8ec33b7#diff-b5bf09a9e8e2ab5019c940fe22bd8b25R34

Full text:

Suite: org.elasticsearch.xpack.watcher.notification.slack.message.SlackMessageTests
  1> [2018-07-10T20:58:22,638][WARN ][o.e.b.JNANatives         ] Unable to lock JVM Memory: error=78, reason=Function not implemented
  1> [2018-07-10T20:58:22,640][WARN ][o.e.b.JNANatives         ] This can result in part of the JVM being swapped out.
  1> [2018-07-11T07:58:23,314][INFO ][o.e.x.w.n.s.m.SlackMessageTests] [testTemplateRender]: before test
  1> [2018-07-11T07:58:23,507][INFO ][o.e.x.w.n.s.m.SlackMessageTests] [testTemplateRender]: after test
  2> REPRODUCE WITH: ./gradlew :x-pack:plugin:watcher:test -Dtests.seed=7E16EC5523F952E7 -Dtests.class=org.elasticsearch.xpack.watcher.notification.slack.message.SlackMessageTests -Dtests.method="testTemplateRender" -Dtests.security.manager=true -Dtests.locale=hr -Dtests.timezone=Asia/Omsk
ERROR   0.22s | SlackMessageTests.testTemplateRender <<< FAILURES!
   > Throwable #1: java.lang.IllegalArgumentException: Both text and attachments cannot be null.
   >    at __randomizedtesting.SeedInfo.seed([7E16EC5523F952E7:5C93EBB62B66EC8]:0)
   >    at org.elasticsearch.xpack.watcher.notification.slack.message.SlackMessage.<init>(SlackMessage.java:35)
   >    at org.elasticsearch.xpack.watcher.notification.slack.message.SlackMessage$Template.render(SlackMessage.java:210)
   >    at org.elasticsearch.xpack.watcher.notification.slack.message.SlackMessageTests.testTemplateRender(SlackMessageTests.java:497)
   >    at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
   >    at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
   >    at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
   >    at java.base/java.lang.reflect.Method.invoke(Method.java:564)
   >    at java.base/java.lang.Thread.run(Thread.java:844)
  2> NOTE: leaving temporary files on disk at: /Users/jake/workspace/elasticsearch/x-pack/plugin/watcher/build/testrun/test/J0/temp/org.elasticsearch.xpack.watcher.notification.slack.message.SlackMessageTests_7E16EC5523F952E7-001
  2> NOTE: test params are: codec=Asserting(Lucene70), sim=RandomSimilarity(queryNorm=true): {}, locale=hr, timezone=Asia/Omsk
  2> NOTE: Mac OS X 10.12.6 x86_64/Oracle Corporation 10.0.1 (64-bit)/cpus=8,threads=1,free=493009280,total=536870912
  2> NOTE: All tests run in this JVM: [SlackMessageTests]
Completed [1/1] in 1.50s, 1 test, 1 error <<< FAILURES!

cc: @hub-cap

The text was updated successfully, but these errors were encountered:

elasticmachine · 2018-07-11T02:05:09Z

Pinging @elastic/es-core-infra

spinscale · 2018-07-11T09:16:03Z

@hub-cap can you take a look? Might be caused by #31596

ywelsch · 2018-07-11T09:16:22Z

I've muted the test in dadf96a

hub-cap · 2018-07-11T14:18:16Z

on it. I already backported the other test this morning tho before seeing this. Should i push a mute to that test too?

A new commit was merged that does not allow a null attachement && text. This is valid for the slack API, as it does not allow this, but our unit tests did. This commit fixes the broken unit test. Closes elastic#31948

hub-cap · 2018-07-11T14:33:10Z

I have a fix for this in #31968

A new commit was merged that does not allow a null attachement && text. This is valid for the slack API, as it does not allow this, but our unit tests did. This commit fixes the broken unit test. Closes #31948

martijnvg · 2018-07-12T09:12:38Z

@hub-cap This error is still occuring: https://elasticsearch-ci.elastic.co/job/elastic+elasticsearch+6.x+multijob-unix-compatibility/os=sles/1176/

First I thought the last good commit was not up to date, but it seems to use a commit after you pushed the fix.

  2> NOTE: leaving temporary files on disk at: /var/lib/jenkins/workspace/elastic+elasticsearch+6.x+multijob-unix-compatibility/os/sles/x-pack/plugin/watcher/build/testrun/test/J3/temp/org.elasticsearch.xpack.watcher.notification.slack.message.SlackMessageTests_C35892AD1F91E7C7-001
08:21:48    > Throwable #1: java.lang.IllegalArgumentException: Both text and attachments cannot be null.
08:21:48    > 	at __randomizedtesting.SeedInfo.seed([C35892AD1F91E7C7:B88740435EDEDBE8]:0)
08:21:48   2> NOTE: test params are: codec=Asserting(Lucene70): {}, docValues:{}, maxPointsInLeafNode=428, maxMBSortInHeap=6.408206805655725, sim=RandomSimilarity(queryNorm=true): {}, locale=ar, timezone=America/Coral_Harbour
08:21:48   2> NOTE: Linux 4.4.103-6.38-default amd64/Oracle Corporation 1.8.0_172 (64-bit)/cpus=16,threads=1,free=341246616,total=505937920
08:21:48    > 	at org.elasticsearch.xpack.watcher.notification.slack.message.SlackMessage.<init>(SlackMessage.java:35)
08:21:48   2> NOTE: All tests run in this JVM: [CronEvalToolTests, IncidentEventDefaultsTests, ArrayCompareConditionSearchTests, HipChatAccountsTests, WatcherTransportActionTests, HistoryTemplateEmailMappingsTests, TransportWatcherStatsActionTests, PagerDutyActionTests, ChainTransformTests, MapPathTests, SlackMessageTests]
08:21:48    > 	at org.elasticsearch.xpack.watcher.notification.slack.message.SlackMessage$Template.render(SlackMessage.java:210)
08:21:48    > 	at org.elasticsearch.xpack.watcher.notification.slack.message.SlackMessageTests.testTemplateRender(SlackMessageTests.java:497)
08:21:48    > 	at java.lang.Thread.run(Thread.java:748)

original-brownbear · 2018-07-12T09:15:57Z

+1 this is still failing for me locally with master as well


> Task :x-pack:plugin:watcher:test
==> Test Info: seed=53EDEE31F2D2E609; jvms=4; suites=139

Suite: org.elasticsearch.xpack.watcher.notification.slack.message.SlackMessageTests
  1> [2018-07-12T09:11:18,855][INFO ][o.e.x.w.n.s.m.SlackMessageTests] [testTemplateRender]: before test
  1> [2018-07-12T09:11:18,857][INFO ][o.e.x.w.n.s.m.SlackMessageTests] [testTemplateRender]: after test
  2> REPRODUCE WITH: ./gradlew :x-pack:plugin:watcher:test -Dtests.seed=53EDEE31F2D2E609 -Dtests.class=org.elasticsearch.xpack.watcher.notification.slack.message.SlackMessageTests -Dtests.method="testTemplateRender" -Dtests.security.manager=true -Dtests.locale=pt -Dtests.timezone=Africa/Bissau
ERROR   0.01s J3 | SlackMessageTests.testTemplateRender <<< FAILURES!

cbuescher · 2018-07-12T20:40:06Z

This still fails reproducibly on master:

REPRODUCE WITH:

 ./gradlew :x-pack:plugin:watcher:test -Dtests.seed=D037A2BE0DBB13AD -Dtests.class=org.elasticsearch.xpack.watcher.notification.slack.message.SlackMessageTests -Dtests.method="testTemplateRender" -Dtests.security.manager=true -Dtests.locale=en -Dtests.timezone=Atlantic/Azores

cbuescher · 2018-07-12T20:42:27Z

@hub-cap I muted this again in 332c134, maybe its a different reason now but the error looks different. Could you check?

cbuescher · 2018-07-12T20:46:38Z

Also muted 6.x with where the same reproduction worked with fb6cce0

hub-cap · 2018-07-13T14:27:07Z

Thanks, ill verify. I thought there could be some funkyness with this change and the random behavior. Ill get on it, sorry for the noise.

There was still a case with a null text that allowed for 0 attachments to be created. This commit ensures that greater than zero are created if the text is null. Otherwise, it uses the same logic to create 0 to 3 random attachments. Closes #31948

hub-cap · 2018-07-13T15:09:06Z

fixed and backported and tested with -Dtests.iters=2000 :)

cbuescher · 2018-07-13T15:51:00Z

jakelandis added >test-failure Triaged test failures from CI :Data Management/Watcher labels Jul 11, 2018

jakelandis mentioned this issue Jul 11, 2018

ingest: date_index_name processor template resolution #31841

Merged

ywelsch mentioned this issue Jul 11, 2018

Slack message empty text #31596

Merged

spinscale assigned hub-cap Jul 11, 2018

hub-cap mentioned this issue Jul 11, 2018

Test: fix null failure in watcher test #31968

Merged

hub-cap closed this as completed in #31968 Jul 11, 2018

cbuescher reopened this Jul 12, 2018

hub-cap closed this as completed in 1bf205f Jul 13, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[test failure] :x-pack:plugin:watcher:test can fail with java.lang.IllegalArgumentException: Both text and attachments cannot be null. #31948

[test failure] :x-pack:plugin:watcher:test can fail with java.lang.IllegalArgumentException: Both text and attachments cannot be null. #31948

jakelandis commented Jul 11, 2018

elasticmachine commented Jul 11, 2018

spinscale commented Jul 11, 2018

ywelsch commented Jul 11, 2018

hub-cap commented Jul 11, 2018

hub-cap commented Jul 11, 2018

martijnvg commented Jul 12, 2018

original-brownbear commented Jul 12, 2018 •

edited

Loading

cbuescher commented Jul 12, 2018

cbuescher commented Jul 12, 2018

cbuescher commented Jul 12, 2018

hub-cap commented Jul 13, 2018

hub-cap commented Jul 13, 2018

cbuescher commented Jul 13, 2018 •

edited

Loading

[test failure] :x-pack:plugin:watcher:test can fail with java.lang.IllegalArgumentException: Both text and attachments cannot be null. #31948

[test failure] :x-pack:plugin:watcher:test can fail with java.lang.IllegalArgumentException: Both text and attachments cannot be null. #31948

Comments

jakelandis commented Jul 11, 2018

elasticmachine commented Jul 11, 2018

spinscale commented Jul 11, 2018

ywelsch commented Jul 11, 2018

hub-cap commented Jul 11, 2018

hub-cap commented Jul 11, 2018

martijnvg commented Jul 12, 2018

original-brownbear commented Jul 12, 2018 • edited Loading

cbuescher commented Jul 12, 2018

cbuescher commented Jul 12, 2018

cbuescher commented Jul 12, 2018

hub-cap commented Jul 13, 2018

hub-cap commented Jul 13, 2018

cbuescher commented Jul 13, 2018 • edited Loading

original-brownbear commented Jul 12, 2018 •

edited

Loading

cbuescher commented Jul 13, 2018 •

edited

Loading