-
Notifications
You must be signed in to change notification settings - Fork 24.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate keyword_repeat in favor of the new multiplexer filter #33562
Comments
Pinging @elastic/es-search-aggs |
One caveat might be that the currently according to the docs "the Multiplexer does not work for Shingle or multi-word synonym token filters declared in the filters array because they read ahead internally which is unsupported by the multiplexer". I'm not entirely sure if this makes them a full substitute for the "keyword_repeat" filter of if that also has issues with multi-word synonyms. |
The multiplexer essentially creates branches in the TokenStream and passes each token one-by-one to each branch in turn, so any filter within a branch that reads ahead in its tokenstream is going to break things. However, you can place filters after the multiplexer which in effect merge the stream again, and reading ahead will work fine there. I think this is fine to do, we may well end up deprecating |
Pinging @elastic/es-search-relevance (Team:Search Relevance) |
Looking at the docs,
keyword_repeat
seems to be mostly designed as a way to have both stemmed and original tokens indexed, which is now better handled by themultiplexer
filter.Should we deprecate
keyword_repeat
?The text was updated successfully, but these errors were encountered: