Loading templates via templates/ directory is not working #4235
Labels
Comments
spinscale
added a commit
that referenced
this issue
Nov 27, 2013
When parsing the json file, the first field is ignored as parser.nextToken() seems to be called too often. Closes #4235
spinscale
added a commit
to spinscale/elasticsearch
that referenced
this issue
Dec 17, 2013
We support three different settings in templates
* "settings" : { "index" : { "number_of_shards" : 12 } }
* "settings" : { "index.number_of_shards" : 12 }
* "settings" : { "number_of_shards" : 12 }
The latter one was not supported by the fix in elastic#4235
This commit fixes this issue and uses randomized testing to test any of the three cases above when running integration tests.
Closes elastic#4411
spinscale
added a commit
that referenced
this issue
Dec 17, 2013
We support three different settings in templates
* "settings" : { "index" : { "number_of_shards" : 12 } }
* "settings" : { "index.number_of_shards" : 12 }
* "settings" : { "number_of_shards" : 12 }
The latter one was not supported by the fix in #4235
This commit fixes this issue and uses randomized testing to test any of the three cases above when running integration tests.
Closes #4411
spinscale
added a commit
to spinscale/elasticsearch
that referenced
this issue
Dec 20, 2013
The fixes introduced in elastic#4235 and elastic#4411 do not take into account, that a template JSON in the config/ directory includes a template name, as opposed when calling the Put Template API. This PR allows to put both formats (either specifying a template name or not) into files. However you template name/id may not be one of the template element names like "template", "settings", "order" or "mapping". Closes elastic#4511
spinscale
added a commit
that referenced
this issue
Dec 22, 2013
The fixes introduced in #4235 and #4411 do not take into account, that a template JSON in the config/ directory includes a template name, as opposed when calling the Put Template API. This PR allows to put both formats (either specifying a template name or not) into files. However you template name/id may not be one of the template element names like "template", "settings", "order" or "mapping". Closes #4511
spinscale
added a commit
that referenced
this issue
Dec 22, 2013
The fixes introduced in #4235 and #4411 do not take into account, that a template JSON in the config/ directory includes a template name, as opposed when calling the Put Template API. This PR allows to put both formats (either specifying a template name or not) into files. However you template name/id may not be one of the template element names like "template", "settings", "order" or "mapping". Closes #4511
|
This still doesn't seem to work for me. I've used example given in http://www.elasticsearch.org/guide/en/elasticsearch/reference/current/indices-templates.html#config but after restart, Elasticsearch 0.9.10. |
brusic
pushed a commit
to brusic/elasticsearch
that referenced
this issue
Jan 19, 2014
We support three different settings in templates
* "settings" : { "index" : { "number_of_shards" : 12 } }
* "settings" : { "index.number_of_shards" : 12 }
* "settings" : { "number_of_shards" : 12 }
The latter one was not supported by the fix in elastic#4235
This commit fixes this issue and uses randomized testing to test any of the three cases above when running integration tests.
Closes elastic#4411
brusic
pushed a commit
to brusic/elasticsearch
that referenced
this issue
Jan 19, 2014
The fixes introduced in elastic#4235 and elastic#4411 do not take into account, that a template JSON in the config/ directory includes a template name, as opposed when calling the Put Template API. This PR allows to put both formats (either specifying a template name or not) into files. However you template name/id may not be one of the template element names like "template", "settings", "order" or "mapping". Closes elastic#4511
mute
pushed a commit
to mute/elasticsearch
that referenced
this issue
Jul 29, 2015
When parsing the json file, the first field is ignored as parser.nextToken() seems to be called too often. Closes elastic#4235
mute
pushed a commit
to mute/elasticsearch
that referenced
this issue
Jul 29, 2015
We support three different settings in templates
* "settings" : { "index" : { "number_of_shards" : 12 } }
* "settings" : { "index.number_of_shards" : 12 }
* "settings" : { "number_of_shards" : 12 }
The latter one was not supported by the fix in elastic#4235
This commit fixes this issue and uses randomized testing to test any of the three cases above when running integration tests.
Closes elastic#4411
mute
pushed a commit
to mute/elasticsearch
that referenced
this issue
Jul 29, 2015
The fixes introduced in elastic#4235 and elastic#4411 do not take into account, that a template JSON in the config/ directory includes a template name, as opposed when calling the Put Template API. This PR allows to put both formats (either specifying a template name or not) into files. However you template name/id may not be one of the template element names like "template", "settings", "order" or "mapping". Closes elastic#4511
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Seems that with 0.90.7/master loading files via the
config/templatesdirectory does not work.The problem is, that the parsed file jumps over the first while parsing, which results in the template not being set, if it is the first.
Going to send a PR in a second.
The text was updated successfully, but these errors were encountered: